From: James Hogan <james.hogan@imgtec.com>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
Chris Ball <cjb@laptop.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Will Newton <will.newton@imgtec.com>
Subject: Re: mmc: dw_mmc: miscaculated the fifo-depth with wrong bit operation
Date: Mon, 9 Jan 2012 09:41:15 +0000 [thread overview]
Message-ID: <4F0AB63B.4030202@imgtec.com> (raw)
In-Reply-To: <4F0A3DA4.8010909@samsung.com>
On 01/09/2012 01:06 AM, Jaehoon Chung wrote:
> In FIFOTH register, can find "bit[27:16] = FIFO_DEPTH - 1".
> Finally, FIFO_DEPTH = bit[27:16] + 1.
>
> Now, Used the 0x7ff. but 0xfff is right.
Nice catch. The patch itself looks okay, but I don't think the commit
message is very understandable, maybe something like this would be better?:
In FIFOTH register, the RX_WMark field (bits[27:16]) defaults to
FIFO_DEPTH - 1. When reading it, bits[26:16] were being used, so fix it
to use the mask 0xfff instead of 0x7ff.
Cheers
James
next prev parent reply other threads:[~2012-01-09 9:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 1:06 mmc: dw_mmc: miscaculated the fifo-depth with wrong bit operation Jaehoon Chung
2012-01-09 9:41 ` James Hogan [this message]
2012-01-11 9:28 ` James Hogan
2012-01-11 9:59 ` Jaehoon Chung
2012-01-11 19:14 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0AB63B.4030202@imgtec.com \
--to=james.hogan@imgtec.com \
--cc=cjb@laptop.org \
--cc=jh80.chung@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=will.newton@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.