All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH] syscalls/xattr: fix compile when xattr.h not exist
Date: Mon, 9 Jan 2012 09:54:00 +0000	[thread overview]
Message-ID: <4F0AB938.9050504@imgtec.com> (raw)
In-Reply-To: <1326102275-32485-1-git-send-email-caspar@casparzhang.com>

On 01/09/2012 09:44 AM, Caspar Zhang wrote:
>
> if<attr/xattr.h>  doesn't exist, compliation will fail. Fix it in
> autotools level.
>
> Signed-off-by: Caspar Zhang<caspar@casparzhang.com>
> ---
>   configure.ac                                    |    1 +
>   testcases/kernel/syscalls/getxattr/getxattr01.c |   15 +++++++++++++--
>   testcases/kernel/syscalls/getxattr/getxattr02.c |   16 +++++++++++++---
>   testcases/kernel/syscalls/setxattr/setxattr01.c |   15 +++++++++++++--
>   testcases/kernel/syscalls/setxattr/setxattr02.c |   16 +++++++++++++---
>   5 files changed, 53 insertions(+), 10 deletions(-)
>
>
>
>
The patch looks good to me. Another approach would be to disable these 
two tests for all UCLINUX targets (uClibc does not have attr/xattr.h>) 
from testcases/kernel/syscalls Makefile.

-- 
markos


------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual 
desktops for less than the cost of PCs and save 60% on VDI infrastructure 
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2012-01-09  9:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-09  9:44 [LTP] [PATCH] syscalls/xattr: fix compile when xattr.h not exist Caspar Zhang
2012-01-09  9:54 ` Markos Chandras [this message]
2012-01-09 17:09   ` Garrett Cooper
2012-01-09 17:17   ` Mike Frysinger
2012-01-09 10:51 ` Eryu Guan
2012-01-09 17:11   ` Garrett Cooper
2012-01-09 17:23     ` Mike Frysinger
2012-01-09 17:32       ` Garrett Cooper
2012-01-10  3:01 ` [LTP] [PATCH v2] " Caspar Zhang
2012-01-10  3:30   ` Eryu Guan
2012-01-11 15:24   ` Cyril Hrubis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F0AB938.9050504@imgtec.com \
    --to=markos.chandras@imgtec.com \
    --cc=ltp-list@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.