From: Avi Kivity <avi@redhat.com>
To: Takuya Yoshikawa <takuya.yoshikawa@gmail.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
kvm@vger.kernel.org,
Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>
Subject: Re: [RFC] KVM: x86: emulate movdqa
Date: Mon, 09 Jan 2012 12:02:22 +0200 [thread overview]
Message-ID: <4F0ABB2E.10200@redhat.com> (raw)
In-Reply-To: <20120109175223.620d0d5a95be6f0fb7850bf9@gmail.com>
On 01/09/2012 10:52 AM, Takuya Yoshikawa wrote:
> Avi Kivity <avi@redhat.com> wrote:
>
> > > Can you think of a case where we need to perform alignment checking in
> > > the emulator?
> >
> > The case that x86/svm.c is checking for is a security issue.
> >
> > Guests don't normally turn eflags.AC on, so I don't expect issues
> > there. I also don't see issues with SSE alignment, especially as AVX
> > removes it (for VEX encoded instructions). However, it's good to stick
> > to the spec, there are always surprise issues when you don't.
> >
>
> Isn't it make sense to add Documentation/virtual/kvm/emulator.txt at some
> point in the future?
>
> In some cases it is difficult to know the underlying assumptions.
Sure.
> Explanations about the emulator specific macros may also be helpful.
Those might be better as code comments, where those macros are defined.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2012-01-09 10:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-07 10:26 [RFC] KVM: x86: emulate movdqa Stefan Hajnoczi
2012-01-08 10:32 ` Avi Kivity
2012-01-08 16:21 ` Stefan Hajnoczi
2012-01-08 16:36 ` Gleb Natapov
2012-01-08 16:41 ` Avi Kivity
2012-01-09 8:52 ` Takuya Yoshikawa
2012-01-09 10:02 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0ABB2E.10200@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=stefanha@gmail.com \
--cc=stefanha@linux.vnet.ibm.com \
--cc=takuya.yoshikawa@gmail.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.