All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Young <dyoung@redhat.com>
To: Han Pingtian <hanpt@linux.vnet.ibm.com>
Cc: horms@verge.net.au, kexec@lists.infradead.org
Subject: Re: [PATCH] Correct magic varible of function name in debug code
Date: Mon, 09 Jan 2012 18:13:06 +0800	[thread overview]
Message-ID: <4F0ABDB2.9010200@redhat.com> (raw)
In-Reply-To: <20120109100230.GA29322@hpt.localdomain>

On 01/09/2012 06:02 PM, Han Pingtian wrote:

> The magic varible of function name should be uppercase.
> 
> Signed-off-by: Han Pingtian <hanpt@linux.vnet.ibm.com>
> ---
>  kexec/crashdump.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kexec/crashdump.c b/kexec/crashdump.c
> index e7ac42c..847d080 100644
> --- a/kexec/crashdump.c
> +++ b/kexec/crashdump.c
> @@ -103,7 +103,7 @@ int get_crash_notes_per_cpu(int cpu, uint64_t *addr, uint64_t *len)
>  	*addr = (uint64_t) temp;
>  	*len = MAX_NOTE_BYTES; /* we should get this from the kernel instead */
>  #ifdef DEBUG
> -	printf("%s: crash_notes addr = %Lx\n", __function__, *addr);
> +	printf("%s: crash_notes addr = %Lx\n", __FUNCTION__, *addr);
>  #endif
>  
>  	fclose(fp);



Hi, Han

Glad to see you here.

I post a similar fix for this issue, please see:
http://lists.infradead.org/pipermail/kexec/2011-December/005889.html

-- 
Thanks
Dave

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2012-01-09 10:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-09 10:02 [PATCH] Correct magic varible of function name in debug code Han Pingtian
2012-01-09 10:13 ` Dave Young [this message]
2012-01-09 10:26   ` Han Pingtian
2012-01-09 22:40 ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F0ABDB2.9010200@redhat.com \
    --to=dyoung@redhat.com \
    --cc=hanpt@linux.vnet.ibm.com \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.