All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boaz Harrosh <bharrosh@panasas.com>
To: Benny Halevy <bhalevy@tonian.com>
Cc: NFS list <linux-nfs@vger.kernel.org>
Subject: [PATCH] SQUASHME: pnfsd-exofs: Fix the RAID5 export
Date: Mon, 9 Jan 2012 12:38:57 +0200	[thread overview]
Message-ID: <4F0AC3C1.5040303@panasas.com> (raw)
In-Reply-To: <4F0A9F00.4020308@tonian.com>


BAD RAID Math in layout_get.

TODO: ore_calc_stripe_info, which is already called, as all
the needed information calculated by _align_io. Only that
first_stripe_start is only set in case of RAID, but lo_get
always needs it. Move the set of first_stripe_start inside
ore_calc_stripe_info, to the generic part.

Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
---
 fs/exofs/export.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/fs/exofs/export.c b/fs/exofs/export.c
index 8a0e510..621bd11 100644
--- a/fs/exofs/export.c
+++ b/fs/exofs/export.c
@@ -96,7 +96,8 @@ void ore_layout_2_pnfs_layout(struct pnfs_osd_layout *pl,
 
 static void _align_io(struct ore_layout *layout, u64 *offset, u64 *length)
 {
-	u64 stripe_size = layout->group_width * layout->stripe_unit;
+	u64 stripe_size = (layout->group_width - layout->parity) *
+							layout->stripe_unit;
 	u64 group_size = stripe_size * layout->group_depth;
 
 	*offset = div64_u64(*offset, group_size) * group_size;
-- 
1.7.2.3



  reply	other threads:[~2012-01-09 10:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-14 16:16 pnfs git tree status pnfs-all-3.1-2011-11-14 pnfs-all-3.2-rc1-2011-11-14 Benny Halevy
2011-11-14 17:23 ` Peng Tao
2011-11-14 17:57   ` Benny Halevy
2011-11-14 19:38 ` Boaz Harrosh
2011-11-15  4:11   ` Benny Halevy
2011-11-15  4:15     ` Benny Halevy
2011-12-04 17:24 ` pnfs git tree status pnfs-all-3.2-rc4-2011-12-04 Benny Halevy
2012-01-09  8:02   ` pnfs git tree status pnfs-all-3.2-2012-01-08 Benny Halevy
2012-01-09 10:38     ` Boaz Harrosh [this message]
2012-01-09 10:43       ` [PATCH] SQUASHME: pnfsd-exofs: Fix the RAID5 export Boaz Harrosh
2012-01-11 10:54         ` Benny Halevy
2012-02-23 19:42     ` pnfs git tree status pnfs-all-3.2-2012-02-22 Benny Halevy
2012-05-17 11:29 ` pnfs git tree status pnfs-all-3.4-rc7-2012-05-17 Benny Halevy
2012-05-21 15:44   ` pnfs git tree status pnfs-all-3.4-2012-05-21 Benny Halevy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F0AC3C1.5040303@panasas.com \
    --to=bharrosh@panasas.com \
    --cc=bhalevy@tonian.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.