Re: [PATCH 0/4] Enable uAPSD support in AP mode

[Kalle Valo <kvalo@qca.qualcomm.com>]

On 01/09/2012 10:54 AM, Johannes Berg wrote:
> On Mon, 2012-01-09 at 13:14 +0530, Thirumalai wrote:
>> In addition to legacy power save, this series of patch adds
>> support for uAPSD in AP mode.
>>
>> When connected station goes into suspend state, the driver will
>> start queuing pkts in the separate queue (called uapsd queue)
>> until the station ask for it. 
>>
>> The moment driver starting queuing, it will enable traffic indication
>> bit for the client connected to indicate data availability. 
>> Once station ask for the data (via Trigger frame), the driver will 
>> dequeue and send pkt one by one to the station.
> 
> The way you describe this sounds incorrect, but I'll leave it to Kalle
> to figure out what you're doing and whether it is correct or not ... if
> only some ACs are trigger-enabled those don't influence the TIM bit.

Yeah, that does sound odd. Thirumalai, does the code really this way or
is it just a problem with the description? (I need to study the code in
detail still.)

Johannes, thanks for pointing this out.

Kalle