From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:58141)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RkKsg-0003HH-Dk
	for qemu-devel@nongnu.org; Mon, 09 Jan 2012 14:27:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RkKsf-0002Nc-3D
	for qemu-devel@nongnu.org; Mon, 09 Jan 2012 14:27:42 -0500
Received: from cantor2.suse.de ([195.135.220.15]:49080 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RkKse-0002NX-Ua
	for qemu-devel@nongnu.org; Mon, 09 Jan 2012 14:27:41 -0500
Message-ID: <4F0B3F51.8060807@suse.de>
Date: Mon, 09 Jan 2012 20:26:09 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1326124572-8312-1-git-send-email-aliguori@us.ibm.com>
	<1326124572-8312-3-git-send-email-aliguori@us.ibm.com>
In-Reply-To: <1326124572-8312-3-git-send-email-aliguori@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 03/11] check-qdict: convert to gtest
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>

Am 09.01.2012 16:56, schrieb Anthony Liguori:
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> ---
>  Makefile       |    6 --
>  check-qdict.c  |  246 +++++++++++++++++++++++++-----------------------=
--------
>  configure      |    4 +-
>  tests/Makefile |    6 ++
>  4 files changed, 119 insertions(+), 143 deletions(-)

> diff --git a/Makefile b/Makefile
> index 80fb512..4823144 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -294,12 +294,6 @@ endif
>  test speed: all
>  	$(MAKE) -C tests/tcg $@
> =20
> -.PHONY: check
> -check: $(patsubst %,run-check-%,$(CHECKS))
> -
> -run-check-%: %
> -	./$<
> -
>  .PHONY: TAGS
>  TAGS:
>  	find "$(SRC_PATH)" -name '*.[hc]' -print0 | xargs -0 etags

> diff --git a/tests/Makefile b/tests/Makefile
> index c11d980..cff9ff3 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -29,3 +29,9 @@ test-qmp-input-visitor: test-qmp-input-visitor.o $(qo=
bject-obj-y) $(qapi-obj-y)
>  test-qmp-commands.o: $(addprefix $(qapi-dir)/, test-qapi-types.c test-=
qapi-types.h test-qapi-visit.c test-qapi-visit.h test-qmp-marshal.c test-=
qmp-commands.h) $(qapi-obj-y)
>  test-qmp-commands: test-qmp-commands.o $(qobject-obj-y) $(qapi-obj-y) =
$(tools-obj-y) $(qapi-dir)/test-qapi-visit.o $(qapi-dir)/test-qapi-types.=
o $(qapi-dir)/test-qmp-marshal.o module.o
> =20
> +.PHONY: check
> +check: $(patsubst %,run-check-%,$(CHECKS))
> +
> +run-check-%: %
> +	./$<
> +

These should be squashed into 02/11. Unrelated to check-qdict.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg