From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkL1y-0006yM-UG for qemu-devel@nongnu.org; Mon, 09 Jan 2012 14:37:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RkL1x-0003nM-Sb for qemu-devel@nongnu.org; Mon, 09 Jan 2012 14:37:18 -0500 Received: from cantor2.suse.de ([195.135.220.15]:49519 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkL1x-0003nE-LB for qemu-devel@nongnu.org; Mon, 09 Jan 2012 14:37:17 -0500 Message-ID: <4F0B4191.9000309@suse.de> Date: Mon, 09 Jan 2012 20:35:45 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1326124572-8312-1-git-send-email-aliguori@us.ibm.com> <1326124572-8312-10-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1326124572-8312-10-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 10/11] test: eliminate libcheck tests and have make check use gtester List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Luiz Capitulino Am 09.01.2012 16:56, schrieb Anthony Liguori: > Signed-off-by: Anthony Liguori > --- > configure | 33 +-------------------------------- > tests/Makefile | 11 ++++++----- > 2 files changed, 7 insertions(+), 37 deletions(-) > diff --git a/tests/Makefile b/tests/Makefile > index cff9ff3..cba482f 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -1,3 +1,7 @@ > +CHECKS=3Dcheck-qdict check-qfloat check-qint check-qstring check-qlist > +CHECKS+=3Dcheck-qjson test-coroutine test-qmp-output-visitor > +CHECKS+=3Dtest-qmp-input-visitor I think we're using VAR =3D value1 value2 VAR +=3D value3 value4 elsewhere (e.g., Makefile.objs), which resembles our Coding Style. Might it make sense to put coroutine on its own line (so that one can comment it out) and semantically group the QMP visitors into one line instead? Otherwise very nice. Looking forward to using gtester with qtest. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg