From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkLOp-0001OC-Bh for qemu-devel@nongnu.org; Mon, 09 Jan 2012 15:01:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RkLOn-00086H-9e for qemu-devel@nongnu.org; Mon, 09 Jan 2012 15:00:55 -0500 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:36775) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkLOm-00085t-KD for qemu-devel@nongnu.org; Mon, 09 Jan 2012 15:00:53 -0500 Message-ID: <4F0B4754.3040405@weilnetz.de> Date: Mon, 09 Jan 2012 21:00:20 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1326124572-8312-1-git-send-email-aliguori@us.ibm.com> <4F0B1016.2010600@us.ibm.com> In-Reply-To: <4F0B1016.2010600@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Please read: make check framework List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Mark McLoughlin , "Michael S. Tsirkin" , qemu-devel@nongnu.org, Alexander Graf , Blue Swirl , Max Filippov , Gerd Hoffmann , "Edgar E. Iglesias" , Peter Maydell , Markus Armbruster , =?ISO-8859-1?Q?Andreas_F=E4rber?= , =?ISO-8859-1?Q?Herv=E9_Poussineau?= , Avi Kivity , Stefan Hajnoczi , Stefano Stabellini , Stefan Weil , Riku Voipio , Jan Kiszka , Paul Brook , Daniel Gollub , Luiz Capitulino , "Venkateswararao Jujjuri (JV)" , Richard Henderson , Kevin Wolf , "Vassili Karpov (malc)" , Marcelo Tosatti , Michael Walle , Amit Shah , Paolo Bonzini , Aurelien Jarno Am 09.01.2012 17:04, schrieb Anthony Liguori: > Hi, > > I'm going to apply this series quickly and will start running 'make > check-quick' as part a sniff test before pushing patches. > > I'd like to request that all maintainers/submaintainers do the same > and that everyone contributes unit tests to this target. > > The general rules for 'make check-quick': > > 1) It must complete in less than 10 minutes start to finish (the > entire rule). We can re-examine this over time but for now, it seems > like a reasonable limit. > > 2) It must gracefully degrade across architectures/targets. Do not > assume qemu-system-x86_64 is present or that an arm cross compiler is > available. > > It would also be nice to get this integrated as part of buildbot. > Stefan/Daniel, is that something we can do? > > Regards, > > Anthony Liguori Hi, 'make check-quick' sounds unusual for me. I'm not a native speaker, so I compared the frequency of "check quick" and "quick check" using Google. 'make quick-check' would sound better, but even that is a Makefile target which I never saw before. There is a standard for the commonly used 'make check' (http://www.gnu.org/prep/standards/html_node/Standard-Targets.html). I'd stick to that standard and allow users to select the tests which should be run by Makefile macros. So make check-quick could be replaced by make check TESTS=quick Macro TESTS could be used to select a list of tests, for example TESTS=tcg,block,pci or TESTS=mips,s390. The supported keywords should be similar to the keywords used in MAINTAINERS. Then committers or maintainers can select which tests are needed for their commits. Other keywords like 'quick' or 'all' select a predefined subset or all tests, and individual tests can be specified by some kind of hierarchical name like for example 'pci/net/e1000'. Regards, Stefan Weil