From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40046) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkLQH-0001xV-RD for qemu-devel@nongnu.org; Mon, 09 Jan 2012 15:02:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RkLQG-0008Gv-KU for qemu-devel@nongnu.org; Mon, 09 Jan 2012 15:02:25 -0500 Received: from cantor2.suse.de ([195.135.220.15]:51200 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkLQG-0008Gk-CE for qemu-devel@nongnu.org; Mon, 09 Jan 2012 15:02:24 -0500 Message-ID: <4F0B4773.3020609@suse.de> Date: Mon, 09 Jan 2012 21:00:51 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1326124572-8312-1-git-send-email-aliguori@us.ibm.com> <1326124572-8312-11-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1326124572-8312-11-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 11/11] check: add a check-report and check-help target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Luiz Capitulino Am 09.01.2012 16:56, schrieb Anthony Liguori: > Signed-off-by: Anthony Liguori > --- > tests/Makefile | 43 ++++++++++++++++++++++++++++++++++++++++--- > 1 files changed, 40 insertions(+), 3 deletions(-) >=20 > diff --git a/tests/Makefile b/tests/Makefile > index cba482f..7228f44 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -33,6 +33,43 @@ test-qmp-input-visitor: test-qmp-input-visitor.o $(q= object-obj-y) $(qapi-obj-y) > test-qmp-commands.o: $(addprefix $(qapi-dir)/, test-qapi-types.c test-= qapi-types.h test-qapi-visit.c test-qapi-visit.h test-qmp-marshal.c test-= qmp-commands.h) $(qapi-obj-y) > test-qmp-commands: test-qmp-commands.o $(qobject-obj-y) $(qapi-obj-y) = $(tools-obj-y) $(qapi-dir)/test-qapi-visit.o $(qapi-dir)/test-qapi-types.= o $(qapi-dir)/test-qmp-marshal.o module.o > =20 > -.PHONY: check > -check: $(CHECKS) > - gtester $(CHECKS) > +check: check-quick > + > +check-slow: $(CHECKS) > + gtester -m=3Dslow $(CHECKS) > + > +check-quick: $(CHECKS) > + gtester -m=3Dquick $(CHECKS) > + > +check-perf: $(CHECKS) > + gtester -m=3Dperf $(CHECKS) > + > +check-help: > + @echo "Regression targets:" > + @echo > + @echo " make check Alias for 'make check-quick'" > + @echo " make check-quick Run all unit tests in 'quick' mode" > + @echo " make check-slow Run all unit tests in 'slow' mode" > + @echo " make check-perf Run all unit tests in 'perf' mode" Are these a fixed set of profiles defined by gtester, or are they arbitrary choices? quick and slow seem intuitive but 'perf' could use an explanation: Is 'perf' more performant than quick, or does it measure performance? (or is it for perfidious test cases?;)) If test cases need to be annotated as slow, describe it in the commit message? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg