From: Troy Kisky <troy.kisky@boundarydevices.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH V2] rtl8192cu: Fix WARNING on suspend/resume
Date: Mon, 09 Jan 2012 17:25:21 -0700 [thread overview]
Message-ID: <4F0B8571.1040106@boundarydevices.com> (raw)
In-Reply-To: <4f0b6e4d.P81fZnkPWac6eQEc%Larry.Finger@lwfinger.net>
On 1/9/2012 3:46 PM, Larry Finger wrote:
>
> +#ifdef CONFIG_PM_SLEEP
> +static int rtl8192cu_usb_suspend(struct usb_interface *pusb_intf,
> + pm_message_t message)
> +{
> + /* Increase usage_count to Save loaded fw across suspend/resume */
> + atomic_inc(&usage_count);
> + return 0;
> +}
> +
>
If firmware is not actively loaded on a 0 to 1 transition of
usage_count, what good is this
atomic_inc doing?
I admit that my understanding is probably at fault, but it looks odd.
I took off list because this message is probably just noise.
Troy
next prev parent reply other threads:[~2012-01-10 0:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 22:46 [PATCH V2] rtl8192cu: Fix WARNING on suspend/resume Larry Finger
2012-01-10 0:25 ` Troy Kisky [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-01-14 20:19 Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0B8571.1040106@boundarydevices.com \
--to=troy.kisky@boundarydevices.com \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.