From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 5/5] ARM:AM33XX: Add SPL support for AM335X EVM
Date: Tue, 10 Jan 2012 09:12:53 +0200 [thread overview]
Message-ID: <4F0BE4F5.8000307@compulab.co.il> (raw)
In-Reply-To: <1326177539-19643-6-git-send-email-chandan.nath@ti.com>
Hi Chandan, Tom,
On 01/10/12 08:38, Chandan Nath wrote:
> This patch is added to support SPL feature on AM335X
> platform. In this patch, MMC1 is configured as boot
> device for SPL and support for other devices will be
> added in the next patch series.
>
> Signed-off-by: Chandan Nath <chandan.nath@ti.com>
> Signed-off-by: Tom Rini <trini@ti.com>
This version looks much better!
The only thing got into my mind while looking at it is that
I would split it to some more patches instead of one big patch,
as it seems that you are mixing the generalization/cleanup with
the actual addition of the SPL, otherwise
Acked-by: Igor Grinberg <grinberg@compulab.co.il>
--
Regards,
Igor.
next prev parent reply other threads:[~2012-01-10 7:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 6:38 [U-Boot] [PATCH v4 0/5] Added SPL support Chandan Nath
2012-01-10 6:38 ` [U-Boot] [PATCH v4 1/5] ARM:AM33XX: Replace CONFIG_AM335X with CONFIG_AM33XX Chandan Nath
2012-01-11 7:14 ` Thomas Weber
2012-01-10 6:38 ` [U-Boot] [PATCH v4 2/5] ARM:AM33XX: Fix ddr and timer register offset Chandan Nath
2012-01-10 6:38 ` [U-Boot] [PATCH v4 3/5] ARM:AM33XX: Fixing AM335X config parameters Chandan Nath
2012-01-10 6:38 ` [U-Boot] [PATCH v4 4/5] ARM:AM33XX: Add mmc/sd support Chandan Nath
2012-01-10 6:38 ` [U-Boot] [PATCH v4 5/5] ARM:AM33XX: Add SPL support for AM335X EVM Chandan Nath
2012-01-10 7:12 ` Igor Grinberg [this message]
2012-01-11 16:04 ` [U-Boot] [PATCH v4 0/5] Added SPL support Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0BE4F5.8000307@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.