From: Ulf Hansson <ulf.hansson@stericsson.com>
To: Dmitry Shmidt <dimitrysh@google.com>
Cc: "Datta, Shubhrajyoti" <shubhrajyoti@ti.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH V3] mmc: Set suspend/resume bus operations if CONFIG_PM_RUNTIME is used
Date: Tue, 10 Jan 2012 09:47:44 +0100 [thread overview]
Message-ID: <4F0BFB30.9040204@stericsson.com> (raw)
In-Reply-To: <CANQgH-buXcVF3Oy1+8=C-OZ3RfC1c=4fiwK9613ccL73gDKMaw@mail.gmail.com>
Datta, Shubhrajyoti wrote:
> Hi Dmitry,
>
>
> On Mon, Jan 9, 2012 at 11:34 PM, Dmitry Shmidt <dimitrysh@google.com> wrote:
>> Signed-off-by: Dmitry Shmidt <dimitrysh@google.com>
>> ---
>> drivers/mmc/card/block.c | 4 ++--
>> drivers/mmc/core/bus.c | 27 +++++++++------------------
>> include/linux/mmc/card.h | 2 +-
>> 3 files changed, 12 insertions(+), 21 deletions(-)
>>
>> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
>> index 1e0e27c..5724ae1 100644
>> --- a/drivers/mmc/card/block.c
>> +++ b/drivers/mmc/card/block.c
>> @@ -1676,8 +1676,8 @@ static void mmc_blk_remove(struct mmc_card *card)
>> mmc_set_drvdata(card, NULL);
>> }
>>
>> -#ifdef CONFIG_PM
>> -static int mmc_blk_suspend(struct mmc_card *card, pm_message_t state)
>> +#ifdef CONFIG_PM_SLEEP
>> +static int mmc_blk_suspend(struct mmc_card *card)
>> {
>> struct mmc_blk_data *part_md;
>> struct mmc_blk_data *md = mmc_get_drvdata(card);
>> diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c
>> index 6be4924..f325aa6 100644
>> --- a/drivers/mmc/core/bus.c
>> +++ b/drivers/mmc/core/bus.c
>> @@ -122,18 +122,19 @@ static int mmc_bus_remove(struct device *dev)
>> return 0;
>> }
>>
>> -static int mmc_bus_suspend(struct device *dev, pm_message_t state)
>> +#ifdef CONFIG_PM_SLEEP
>> +static int mmc_bus_pm_suspend(struct device *dev)
> Was the name change intentional.
I believe there should be no reason for changing these names (same for
mmc_bus_resume). Otherwise, great! You will have my Ack!
BR
Ulf Hansson
next prev parent reply other threads:[~2012-01-10 8:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 18:04 [PATCH V3] mmc: Set suspend/resume bus operations if CONFIG_PM_RUNTIME is used Dmitry Shmidt
2012-01-10 7:12 ` Datta, Shubhrajyoti
2012-01-10 8:47 ` Ulf Hansson [this message]
2012-01-10 18:05 ` Dmitry Shmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0BFB30.9040204@stericsson.com \
--to=ulf.hansson@stericsson.com \
--cc=dimitrysh@google.com \
--cc=linux-mmc@vger.kernel.org \
--cc=shubhrajyoti@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.