From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:45547)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1RkZRb-0001IS-TV
	for qemu-devel@nongnu.org; Tue, 10 Jan 2012 06:00:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1RkZRa-0001vm-73
	for qemu-devel@nongnu.org; Tue, 10 Jan 2012 06:00:43 -0500
Received: from mout.web.de ([212.227.15.3]:58922)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1RkZRZ-0001vR-U2
	for qemu-devel@nongnu.org; Tue, 10 Jan 2012 06:00:42 -0500
Message-ID: <4F0C19F4.9040701@web.de>
Date: Tue, 10 Jan 2012 11:59:00 +0100
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
MIME-Version: 1.0
References: <1322596506-31056-1-git-send-email-mlspirat42@gmail.com>
	<CAJSP0QWbcwUFv-0yMx7hvJcsi+X3+VeLvpJA73OEK1taKXbtvw@mail.gmail.com>
	<4F0C6580.3000908@gmail.com>
In-Reply-To: <4F0C6580.3000908@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3] Support for UDP unicast network backend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Benjamin <mlspirat42@gmail.com>, Stefan Hajnoczi <stefanha@gmail.com>
Cc: jan.kiszka@web.de, qemu-devel@nongnu.org

Am 10.01.2012 17:21, schrieb Benjamin:
> On 11/29/11 20:52, Stefan Hajnoczi wrote:
>> On Tue, Nov 29, 2011 at 7:55 PM, Benjamin<mlspirat42@gmail.com>  wrote:
>>>
>>> Signed-off-by: Benjamin<mlspirat42@gmail.com>

A minor nit: the SoB is a legal assertion that you not stole, etc. the
code, and as such it should include first and last name.

>>> ---
>>>   net.c           |    6 ++++-
>>>   net/socket.c    |   73
>>> +++++++++++++++++++++++++++++++++++++++++++++++++++++-
>>>   qemu-options.hx |    2 +
>>>   3 files changed, 78 insertions(+), 3 deletions(-)
>>
>> Reviewed-by: Stefan Hajnoczi<stefanha@linux.vnet.ibm.com>
>>
>>> +    s = net_socket_fd_init(vlan, model, name, fd, 0);
>>> +    if (!s) {
>>> +        return -1;
>>> +    }
>>
>> I'll add a TODO to my list about net_socket_fd_init().  It does not
>> consistently take ownership of fd.  It may return NULL without closing
>> it, but then again it might close it on error in another code path :(.

Hasn't this been taken care of in the meantime? Any changes needed for
that, Stefan?

> Me again, is it supposed to take that long before the patch is
> accepted?

Not supposed to, but sometimes it does...

Andreas