From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: Stefan Roese <sr@denx.de>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] stmmac: Add missing LF to pr_info() in stmmac_main.c
Date: Tue, 10 Jan 2012 15:50:01 +0100 [thread overview]
Message-ID: <4F0C5019.9090103@st.com> (raw)
In-Reply-To: <1326196071-10341-1-git-send-email-sr@denx.de>
On 1/10/2012 12:47 PM, Stefan Roese wrote:
> Otherwise the output looks like this:
>
> ...
> STMMAC - user ID: 0x10, Synopsys ID: 0x32
> No HW DMA feature register supported
> Normal descriptors
> Remote wake-up capable
> Checksum Offload Engine supported
> No MAC Management Counters availableIP-Config: Complete:
> device=eth0, addr=192.168.20.42, mask=255.255.0.0, gw=192.168.1.254,
> ...
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index 3738b47..ee85a14 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -772,7 +772,7 @@ static void stmmac_mmc_setup(struct stmmac_priv *priv)
> dwmac_mmc_ctrl(priv->ioaddr, mode);
> memset(&priv->mmc, 0, sizeof(struct stmmac_counters));
> } else
> - pr_info(" No MAC Management Counters available");
> + pr_info(" No MAC Management Counters available\n");
> }
>
> static u32 stmmac_get_synopsys_id(struct stmmac_priv *priv)
next prev parent reply other threads:[~2012-01-10 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 11:47 [PATCH] stmmac: Add missing LF to pr_info() in stmmac_main.c Stefan Roese
2012-01-10 14:50 ` Giuseppe CAVALLARO [this message]
2012-01-10 22:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0C5019.9090103@st.com \
--to=peppe.cavallaro@st.com \
--cc=netdev@vger.kernel.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.