From: Xiangfu Liu <xiangfu@openmobilefree.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] add nand spl boot for qi_lb60 board
Date: Tue, 10 Jan 2012 23:13:51 +0800 [thread overview]
Message-ID: <4F0C55AF.5040902@openmobilefree.net> (raw)
In-Reply-To: <4F077789.8030401@freescale.com>
Hi Scott
thanks for your comments. PATCH v3 have sent out for you to review.
On 01/07/2012 06:36 AM, Scott Wood wrote:
> We are transitioning from nand_spl/ to spl/. Please try to work within
> the new infrastructure. You may run into problems with size in spl/,
> due to gc-sections not removing strings on components you don't need --
> I plan to fix those issues (for NAND), hopefully this merge window, by
> requiring all files to be explicitly asked for. Feel free to fix them
> first if you'd like. :-)
>
I'd like to move the new spl/. I have one question about the new spl/
I didn't see the new spl/ link to nand_spl/nand_boot.c. so how the new
spl/ using nand_boot()?
can we add a new define 'CONFIG_SPL_START_S_NAME', since qi_lb60 using
start_spl.S for SPL, not start.S.
I think better I make the nand_spl/ working. then move to the new spl/ :)
>> +include $(TOPDIR)/config.mk
>> +
>> +LDSCRIPT= $(TOPDIR)/nand_spl/board/$(BOARDDIR)/u-boot.lds
>> +LDFLAGS = -Bstatic -T $(LDSCRIPT) -Ttext $(CONFIG_NAND_SPL_TEXT_BASE)
>> +AFLAGS += -DCONFIG_NAND_SPL
>> +CFLAGS += -DCONFIG_NAND_SPL -O2
>
> Why -O2 and not the -Os that you should already be inheriting from
> config.mk?
when I remove the -O2. it give me error:
jz4740.c:(.text.sdram_init+0x14): undefined reference to `memcpy'
so I keep the -O2 there. please anyone give me some advice on how to fix this.
that will be great.
thanks again
xiangfu
next prev parent reply other threads:[~2012-01-10 15:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 10:17 [U-Boot] [PATCH v2] add nand spl boot for qi_lb60 board Xiangfu Liu
2012-01-06 22:36 ` Scott Wood
2012-01-10 15:13 ` Xiangfu Liu [this message]
2012-01-10 16:24 ` Daniel Schwierzeck
2012-01-10 18:07 ` Scott Wood
2012-01-10 15:06 ` [U-Boot] [PATCH v3] " Xiangfu Liu
2012-03-06 21:04 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0C55AF.5040902@openmobilefree.net \
--to=xiangfu@openmobilefree.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.