Re: [Qemu-devel] [PATCH v3] Support for UDP unicast network backend

[Benjamin <mlspirat42@gmail.com>]

On 11/29/11 20:52, Stefan Hajnoczi wrote:
> On Tue, Nov 29, 2011 at 7:55 PM, Benjamin<mlspirat42@gmail.com>  wrote:
>>
>> Signed-off-by: Benjamin<mlspirat42@gmail.com>
>> ---
>>   net.c           |    6 ++++-
>>   net/socket.c    |   73 +++++++++++++++++++++++++++++++++++++++++++++++++++++-
>>   qemu-options.hx |    2 +
>>   3 files changed, 78 insertions(+), 3 deletions(-)
>
> Reviewed-by: Stefan Hajnoczi<stefanha@linux.vnet.ibm.com>
>
>> +    s = net_socket_fd_init(vlan, model, name, fd, 0);
>> +    if (!s) {
>> +        return -1;
>> +    }
>
> I'll add a TODO to my list about net_socket_fd_init().  It does not
> consistently take ownership of fd.  It may return NULL without closing
> it, but then again it might close it on error in another code path :(.
>   Don't worry about this for now.
>
> Stefan

Me again, is it supposed to take that long before the patch is
accepted? Did I forget something?

Regards,

Benjamin