From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Antti Palosaari <crope@iki.fi>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH 0/5] Fix dvb-core set_delivery_system and port drxk to one frontend
Date: Tue, 10 Jan 2012 20:22:11 -0200 [thread overview]
Message-ID: <4F0CBA13.7080305@redhat.com> (raw)
In-Reply-To: <4F0CB197.5010306@iki.fi>
On 10-01-2012 19:45, Antti Palosaari wrote:
> On 01/05/2012 05:37 PM, Mauro Carvalho Chehab wrote:
>> With all these series applied, it is now possible to use frontend 0
>> for all delivery systems. As the current tools don't support changing
>> the delivery system, the dvb-fe-tool (on my experimental tree[1]) can now
>> be used to change between them:
>>
>> For example, to use DVB-T with the standard scan:
>>
>> $ ./dvb-fe-tool -d DVBT&& scan /usr/share/dvb/dvb-t/au-Adelaide
>>
>> [1] http://git.linuxtv.org/mchehab/experimental-v4l-utils.git/shortlog/refs/heads/dvb-utils
>
> I tested that now using nanoStick T2 cxd2820r driver. I got it working somehow, but I suspect there is some bugs at least for DVB-C. But forget those as now.
Well, we need to hardly test the DVB drivers after a 200+ patch series.
Regressions will happen. I've cached a few already, but I'm sure there
are others that are not that trivial.
> As it now registers only one frontend I must switch mode using dvb-fe-tool when I want to use DVB-C. Argh.
>
> I don't see reason why it was needed to remove old DVB-C frontend1. Why it wasn't possible to leave FE1
> as it was and enhance only functionality of FE0 like it is now? For that strategy we doesn't break old set-ups as now happens.
This were discussed in the past:
http://www.spinics.net/lists/linux-media/msg35542.html
In fact, I've proposed this strategy as one of the alternatives for MFE
(approach 4):
>>>>> Approach 4) fe0 is a frontend "superset"
>>>>>
>>>>> *adapter0
>>>>> *frontend0 (DVB-S/DVB-S2/DVB-T/DVB-T2/DVB-C/ISDB-T) - aka: FE superset
>>>>> *frontend1 (DVB-S/DVB-S2)
>>>>> *frontend2 (DVB-T/DVB-T2)
>>>>> *frontend3 (DVB-C)
>>>>> *frontend4 (ISDB-T)
The arguments where that it would be confusing and it could be complex
to maintain.
I think that the better is to see what happens with the applications
during this kernel cycle, and then decide what to do. A quick fix for
the issue at the applications side is very easy: for DVBv5.5 and upper,
just try to force the frontend to change to the new delivery system
via a DVBv5 call. If it accepts, it is a multi frontend devnode.
A better fix is to also implement DTV_ENUM_DELSYS.
Regards,
Mauro
prev parent reply other threads:[~2012-01-10 22:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 15:37 [PATCH 0/5] Fix dvb-core set_delivery_system and port drxk to one frontend Mauro Carvalho Chehab
2012-01-05 15:37 ` [PATCH 1/5] [media] drxk: remove ops.info.frequency_stepsize from DVB-C Mauro Carvalho Chehab
2012-01-05 15:37 ` [PATCH 2/5] [media] drxk: create only one frontend for both DVB-C and DVB-T Mauro Carvalho Chehab
2012-01-05 15:37 ` [PATCH 3/5] [media] drxk_hard: fix locking issues when changing the delsys Mauro Carvalho Chehab
2012-01-05 15:37 ` [PATCH 4/5] [media] dvb_frontend: regression fix: add a missing inc inside the loop Mauro Carvalho Chehab
2012-01-05 15:37 ` [PATCH 5/5] [media] dvb_frontend: Update ops.info.type earlier Mauro Carvalho Chehab
2012-01-05 18:47 ` [PATCH v2] [media] dvb_frontend: Update the dynamic info->type Mauro Carvalho Chehab
2012-01-05 16:40 ` [PATCH 0/5] Fix dvb-core set_delivery_system and port drxk to one frontend Devin Heitmueller
2012-01-05 18:35 ` Mauro Carvalho Chehab
2012-01-05 18:38 ` Lars Hanisch
2012-01-06 0:05 ` Mauro Carvalho Chehab
2012-01-06 1:02 ` Oliver Endriss
2012-01-10 21:45 ` Antti Palosaari
2012-01-10 22:22 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0CBA13.7080305@redhat.com \
--to=mchehab@redhat.com \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.