From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48238)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <e.voevodin@samsung.com>) id 1RkqkE-0000gQ-7U
	for qemu-devel@nongnu.org; Wed, 11 Jan 2012 00:29:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <e.voevodin@samsung.com>) id 1RkqkC-0006Gc-W8
	for qemu-devel@nongnu.org; Wed, 11 Jan 2012 00:29:06 -0500
Received: from mailout1.w1.samsung.com ([210.118.77.11]:45313)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <e.voevodin@samsung.com>) id 1RkqkC-0006GE-RJ
	for qemu-devel@nongnu.org; Wed, 11 Jan 2012 00:29:04 -0500
Received: from euspt1 (mailout1.w1.samsung.com [210.118.77.11])
	by mailout1.w1.samsung.com
	(iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004))
	with ESMTP id <0LXM00339CKBOK@mailout1.w1.samsung.com> for
	qemu-devel@nongnu.org; Wed, 11 Jan 2012 05:28:59 +0000 (GMT)
Received: from [106.109.8.195] by spt1.w1.samsung.com
	(iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004))
	with ESMTPA id <0LXM0053LCKA3Q@spt1.w1.samsung.com> for
	qemu-devel@nongnu.org; Wed, 11 Jan 2012 05:28:59 +0000 (GMT)
Date: Wed, 11 Jan 2012 09:28:57 +0400
From: Evgeny Voevodin <e.voevodin@samsung.com>
In-reply-to: <CAFEAcA8c79B3yrD4Z+ug1XHY9Gh78bgsy4+VwocOr6DZ-5OmLg@mail.gmail.com>
Message-id: <4F0D1E19.20308@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=UTF-8; format=flowed
Content-transfer-encoding: 7BIT
References: <1324640414-16000-1-git-send-email-e.voevodin@samsung.com>
	<1324640414-16000-3-git-send-email-e.voevodin@samsung.com>
	<CAFEAcA8c79B3yrD4Z+ug1XHY9Gh78bgsy4+VwocOr6DZ-5OmLg@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v5 02/11] ARM: exynos4210: UART support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: kyungmin.park@samsung.com, m.kozlov@samsung.com, jehyung.lee@samsung.com, qemu-devel@nongnu.org, d.solodkiy@samsung.com

On 01/10/2012 04:11 PM, Peter Maydell wrote:
>> +    case UINTP:
>> +        s->reg[I_(UINTP)]&= ~val;
>> +        /* XXX: It's the assumption that it works in this way */
> Can you expand this comment a little to clarify exactly what the
> assumption you're making is?
It was not clear from documentation if UINTSP register bits should be 
cleared inside
this "case" too. Practise has showed that should. I think, this comment
message could be removed.

-- 
Kind regards,
Evgeny Voevodin,
Leading Software Engineer,
ASWG, Moscow R&D center, Samsung Electronics
e-mail: e.voevodin@samsung.com