From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:60144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkrRQ-0001AJ-Ce for qemu-devel@nongnu.org; Wed, 11 Jan 2012 01:13:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RkrRO-0004FU-UU for qemu-devel@nongnu.org; Wed, 11 Jan 2012 01:13:44 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:57390) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RkrRO-00047t-Pr for qemu-devel@nongnu.org; Wed, 11 Jan 2012 01:13:42 -0500 Received: from euspt1 (mailout2.w1.samsung.com [210.118.77.12]) by mailout2.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTP id <0LXM0071ZEMQ4L@mailout2.w1.samsung.com> for qemu-devel@nongnu.org; Wed, 11 Jan 2012 06:13:38 +0000 (GMT) Received: from [106.109.8.195] by spt1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0LXM008PAEMPYR@spt1.w1.samsung.com> for qemu-devel@nongnu.org; Wed, 11 Jan 2012 06:13:38 +0000 (GMT) Date: Wed, 11 Jan 2012 10:13:37 +0400 From: Evgeny Voevodin In-reply-to: Message-id: <4F0D2891.8040205@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8; format=flowed Content-transfer-encoding: 7BIT References: <1324640414-16000-1-git-send-email-e.voevodin@samsung.com> <1324640414-16000-9-git-send-email-e.voevodin@samsung.com> Subject: Re: [Qemu-devel] [PATCH v5 08/11] hw/exynos4210.c: Boot secondary CPU. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: kyungmin.park@samsung.com, m.kozlov@samsung.com, jehyung.lee@samsung.com, qemu-devel@nongnu.org, d.solodkiy@samsung.com On 01/10/2012 08:16 PM, Peter Maydell wrote: > On 23 December 2011 11:40, Evgeny Voevodin wrote: >> + /* >> + * Hack: Map SECOND_CPU_BOOTREG, because it is in PMU USER5 register. >> + */ > Shouldn't we be modelling the PMU then? > Power Management Unit (PMU) is quite tricky and not critical for emulation. At this time PMU emulation is paused. It just represents about 16K registers array. I don't think that it is a good idea to include such a device into mainline code in order to provide one of it's register for secondary CPU boot-up. >> + memory_region_init_ram(&s->bootreg_mem, NULL, "exynos4210.bootreg", 0x4); >> + memory_region_add_subregion(system_mem, EXYNOS4210_SECOND_CPU_BOOTREG, >> +&s->bootreg_mem); >> + > >> +static int exynos4_board_smp_bootreg_addr[EXYNOS4_NUM_OF_BOARDS] = { >> + [EXYNOS4_BOARD_NURI] = EXYNOS4210_SECOND_CPU_BOOTREG, >> + [EXYNOS4_BOARD_SMDKC210] = EXYNOS4210_SECOND_CPU_BOOTREG, >> +}; > Is this actually likely to differ between boards, or is it really a property > of the SoC itself? > Yes, it is specific to a board. There are different boards on exynos4210 SOC which have different bootreg addresses. At this time we don't emulate them. -- Kind regards, Evgeny Voevodin, Leading Software Engineer, ASWG, Moscow R&D center, Samsung Electronics e-mail: e.voevodin@samsung.com