From: Pavel Emelyanov <xemul@parallels.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: Iproute2 build broken by current kernel headers
Date: Wed, 11 Jan 2012 10:34:48 +0400 [thread overview]
Message-ID: <4F0D2D88.8010705@parallels.com> (raw)
In-Reply-To: <20120110110749.42c1252a@nehalam.linuxnetplumber.net>
On 01/10/2012 11:07 PM, Stephen Hemminger wrote:
> On Tue, 10 Jan 2012 10:54:09 -0800
> Stephen Hemminger <shemminger@vyatta.com> wrote:
>
>> The update to inet diag broke compatibility with exported headers.
>> Iproute2 uses sanitized kernel headers.
>>
>> gcc -D_GNU_SOURCE -O2 -Wstrict-prototypes -Wall -I../include -DRESOLVE_HOSTNAMES -DLIBDIR=\"/usr/lib/\" -c -o ss.o ss.c
>> ss.c: In function ‘tcp_show_netlink’:
>> ss.c:1504:7: error: ‘struct inet_diag_req’ has no member named ‘idiag_family’
>> make[1]: *** [ss.o] Error 1
>
> The structures need to be swapped to maintain source compatibility.
> inet_diag_req_compat needs to be renamed back to inet_diag_req
> inet_diag_req should be named something like inet_diag_req_generic
Stephen, actually the diag modules were patched to be only binary compatible with the ss.
In order to make it compile with new headers I've sent the patches fixing ss, here they are:
http://www.spinics.net/lists/netdev/msg182467.html
http://www.spinics.net/lists/netdev/msg182858.html
http://lists.openwall.net/netdev/2011/12/15/45
next prev parent reply other threads:[~2012-01-11 6:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 18:54 Iproute2 build broken by current kernel headers Stephen Hemminger
2012-01-10 19:07 ` Stephen Hemminger
2012-01-11 6:34 ` Pavel Emelyanov [this message]
2012-01-11 6:39 ` David Miller
2012-01-11 6:58 ` Pavel Emelyanov
2012-01-11 7:03 ` David Miller
2012-01-11 18:24 ` Stephen Hemminger
2012-01-11 18:27 ` Pavel Emelyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0D2D88.8010705@parallels.com \
--to=xemul@parallels.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.