From mboxrd@z Thu Jan 1 00:00:00 1970 From: tangchen Subject: [PATCH] libvirt_vm.py: Set ignore_status to False in virsh_cmd(). Date: Wed, 11 Jan 2012 15:06:48 +0800 Message-ID: <4F0D3508.3020606@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit To: Lucas Meneghel Rodrigues , autotest@test.kernel.org, kvm@vger.kernel.org Return-path: Received: from cn.fujitsu.com ([222.73.24.84]:63083 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752933Ab2AKHUH (ORCPT ); Wed, 11 Jan 2012 02:20:07 -0500 Sender: kvm-owner@vger.kernel.org List-ID: utils.run()'s parameter "ignore_status" is set to "True" in virsh_cmd(). In this case we are not able to know whether the command succeeds. This patch sets it to "False", and utils.run() will throw an exception when command fails. Signed-off-by: Tang Chen --- client/virt/libvirt_vm.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/client/virt/libvirt_vm.py b/client/virt/libvirt_vm.py index c825661..6f30f36 100644 --- a/client/virt/libvirt_vm.py +++ b/client/virt/libvirt_vm.py @@ -38,7 +38,7 @@ def virsh_cmd(cmd, uri = ""): if uri: uri_arg = "-c " + uri - cmd_result = utils.run("%s %s %s" % (VIRSH_EXEC, uri_arg, cmd), ignore_status=True, + cmd_result = utils.run("%s %s %s" % (VIRSH_EXEC, uri_arg, cmd), ignore_status=False, verbose=DEBUG) if DEBUG: if cmd_result.stdout.strip(): -- 1.7.3.1 -- Best Regards, Tang chen -------------------------------------------------- Tang Chen Development Dept.I Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST) No.6 Wenzhu Road, Nanjing, 210012, China TEL: +86+25-86630566-8527 FUJITSU INTERNAL: 7998-8527 FAX: +86+25-83317685 EMail: tangchen@cn.fujitsu.com -------------------------------------------------- This communication is for use by the intended recipient(s) only and may contain information that is privileged, confidential and exempt from disclosure under applicable law. If you are not an intended recipient of this communication, you are hereby notified that any dissemination, distribution or copying hereof is strictly prohibited. If you have received this communication in error, please notify me by reply e-mail, permanently delete this communication from your system, and destroy any hard copies you may have printed