From: Pavel Emelyanov <xemul@parallels.com>
To: David Miller <davem@davemloft.net>,
Stephen Hemminger <shemminger@linux-foundation.org>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: [PATCH 0/2] inet_diag: Fix old/new inet_diag_req-s structures
Date: Wed, 11 Jan 2012 12:35:32 +0400 [thread overview]
Message-ID: <4F0D49D4.7040100@parallels.com> (raw)
The recent changes to inet_diag broke the compilation of tools using kernel headers.
Fix this by doing two sequential renames:
inet_diag_req -> inet_diag_req_v2
inet_diag_req_compat -> inet_diag_req
After this the changes in the user-space visible part of the inet_diag.h are
* add the inet_diag_req_v2
* extend the INET_DIAG_ extensions list
The set applies to current net tree.
David, Stephen, I'm a little bit confused with the situation with this header. Can
you please comment on the (quite ancient) commit 73c1f4a0 ([TCPDIAG]: Just rename
everything to inet_diag) from acme@? This commit did the similar thing with inet_diag
header -- flushed away the old struct and introduced a new one keeping just the binary
compatibility. Why was the breakage of tools caused by this commit considered as
acceptable?
Thanks,
Pavel
next reply other threads:[~2012-01-11 8:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 8:35 Pavel Emelyanov [this message]
2012-01-11 8:36 ` [PATCH 1/2] inet_diag: Rename inet_diag_req into inet_diag_req_v2 Pavel Emelyanov
2012-01-11 8:37 ` [PATCH 2/2] inet_diag: Rename inet_diag_req_compat into inet_diag_req Pavel Emelyanov
2012-01-11 16:52 ` [PATCH 0/2] inet_diag: Fix old/new inet_diag_req-s structures Stephen Hemminger
2012-01-11 20:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0D49D4.7040100@parallels.com \
--to=xemul@parallels.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.