From mboxrd@z Thu Jan  1 00:00:00 1970
From: Cong Wang <xiyou.wangcong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [RFC PATCH 1/2] support adding module-specific parameters
Date: Wed, 11 Jan 2012 17:58:47 +0800
Message-ID: <4F0D5D57.9000804@gmail.com>
References: <1326208786-24344-1-git-send-email-xiyou.wangcong@gmail.com> <4F0CF43E.1020901@redhat.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <initramfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:cc:subject
         :references:in-reply-to:content-type:content-transfer-encoding;
        bh=wCeU28lFLQTUJHannJ4SOQst5DD454I4BVloqWoWK0U=;
        b=aYrBNKq4R41FuRRIuzf+vyh03a/MXpmkD9+EzYmVgu8OCzRKoJsHUfj9giPj/e4KLy
         LGhXTiPTbxW0YzWYGJmxq6xErkbDR6yCeyiG7HhGCSc80JbtW0wRDMQwNSyR0vAbVPoz
         UN4d/9cAo7Ru0vV30Z7ZBD7pP/BamQjkitQy8=
In-Reply-To: <4F0CF43E.1020901-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Sender: initramfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
List-ID: <initramfs.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"; format="flowed"
To: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org

On 01/11/2012 10:30 AM, Dave Young wrote:
> Hi,
>
> Thanks for the effort, before test it I have two comments
>
> On 01/10/2012 11:19 PM, xiyou.wangcong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
>
>> From: Cong Wang<xiyou.wangcong-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>
>> ssh-client module needs a specific parameter, --ssh-key, but
>> this parameter is totally useless for other modules. So, introduce
>> a way to let users to pass module-specific parameters, that is,
>> using colons to separate module name and its parameters, like,
>>
>> 	--add ssh-client:sshkey=/root/.ssh/kdump_id_rsa.pub
>
>
> Seems no way to add param to modules which is not add explicitly
> such as simply run
> ./dracut -l
>
> So also need to find way to add params to the implicit-added modules?


I think you mean -H? Yeah, for cases like -H which selects modules 
automatically, I think we need to add an option in dracut.conf to let 
users specify the module parameters. I will add this...


>>
>> +declare -A dracut_module_args
>> +read_module_args() {
>> +    local _key="${1%%:*}"
>> +    local _val="${1#*:}"
>
>> +    dracut_module_args["$_key"]="$_val"
>
> [ -z "$_key" ] above will fail
>

Yeah, but only when users forget the module name, right? :)