From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH v4 1/3] SIMCOM SIM900 module support
Date: Wed, 11 Jan 2012 05:21:15 -0600 [thread overview]
Message-ID: <4F0D70AB.60904@gmail.com> (raw)
In-Reply-To: <1326293559.6454.234.camel@aeonflux>
[-- Attachment #1: Type: text/plain, Size: 775 bytes --]
Hi Marcel,
>> + /* For obtain correct sms service number */
>> + g_at_chat_send(data->modem, "AT+CSCS=\"GSM\"", NULL,
>> + NULL, NULL, NULL);
>
> you might better introduce a OFONO_VENDOR_SIM900 quirk and use that in
> the SMS atom driver. The phonebook support will also end up overwriting
> this one later on. So I am not even sure this works reliable this way.
> Might be just pure luck with the order of the atom.
>
Actually this is fine assuming the modem does not support UTF-8
character set. The builtin assumption for most atoms is that CSCS is
set to something sane before they're initialized. The phonebook driver
will temporarily switch to UCS2 for the duration of the phonebook read
and restore the previous setting.
Regards,
-Denis
next prev parent reply other threads:[~2012-01-11 11:21 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-26 13:38 [PATCH] SIMCOM SIM900 module support r.r.zaripov
2011-12-27 23:03 ` Denis Kenzior
2011-12-29 12:06 ` [PATCH v3 1/3] " r.r.zaripov
2011-12-28 15:54 ` Denis Kenzior
2012-01-11 13:59 ` [PATCH v4 " r.r.zaripov
2012-01-11 13:59 ` [PATCH v4 2/3] Add SIM900 detection support r.r.zaripov
2012-01-11 14:54 ` Marcel Holtmann
2012-01-12 10:11 ` Renat Zaripov
2012-01-11 13:59 ` [PATCH v4 3/3] Adding a short description for usage of SIM900 plugin r.r.zaripov
2012-01-11 14:52 ` [PATCH v4 1/3] SIMCOM SIM900 module support Marcel Holtmann
2012-01-11 11:21 ` Denis Kenzior [this message]
2012-01-11 15:24 ` Marcel Holtmann
2012-01-11 11:41 ` Denis Kenzior
2012-01-12 10:55 ` Renat Zaripov
2012-01-12 11:52 ` Marcel Holtmann
2012-01-12 12:32 ` [PATCH v5 1/4] This patch add support for SIM900 GSM module r.r.zaripov
2012-01-12 5:52 ` Denis Kenzior
2012-01-12 12:32 ` [PATCH v5 2/4] Add SIM900 detection support r.r.zaripov
2012-01-12 12:32 ` [PATCH v5 3/4] SIM900 driver usage documentation r.r.zaripov
2012-01-12 12:32 ` [PATCH v5 4/4] SIM900 vendor quirk r.r.zaripov
2011-12-29 12:06 ` [PATCH v3 2/3] Add SIM900 detection support r.r.zaripov
2011-12-29 12:06 ` [PATCH v3 3/3] SIM900 driver usage documentation r.r.zaripov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0D70AB.60904@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.