Re: [PATCH 2/4] ath6kl: Introduce new queue for uAPSD.

[Kalle Valo <kvalo@qca.qualcomm.com>]

On 01/09/2012 09:45 AM, Thirumalai wrote:
> Add apsd_info in necessary places to indicate which
> AC's uAPSD is enabled.
> 
> A bit is added in the wmi header (bit 4 of info3)
> to specify uapsd trigger in rx direction (target to host)
> and end of service period in tx direction (host to target)
> 
> Signed-off-by: Thirumalai <tpachamu@qca.qualcomm.com>

[...]

> +#define WMI_DATA_HDR_TRIGGER_MASK      0x1
> +#define WMI_DATA_HDR_TRIGGER_SHIFT     4
> +
> +#define WMI_DATA_HDR_EOSP_MASK      WMI_DATA_HDR_TRIGGER_MASK
> +#define WMI_DATA_HDR_EOSP_SHIFT     WMI_DATA_HDR_TRIGGER_SHIFT

This looks a bit odd, I can't see why you want to use trigger
definitions for eosp. Even if the values are same I don't see the
benefit for using trigger values for eosp. Is there a particular reason
for this?

Kalle