From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] ARM: vexpress: remove incorrect BSYM usage
Date: Wed, 11 Jan 2012 09:19:11 -0600 [thread overview]
Message-ID: <4F0DA86F.3020401@gmail.com> (raw)
In-Reply-To: <20120110120402.GB2336@linaro.org>
On 01/10/2012 06:04 AM, Dave Martin wrote:
> On Mon, Jan 09, 2012 at 04:45:43PM -0600, Rob Herring wrote:
>> From: Rob Herring <rob.herring@calxeda.com>
>>
>> BSYM macro is only needed for assembly files and its usage in c files is
>> wrong, so remove it. The linker will correctly set bit 0 for Thumb2
>> kernels.
>
> Pawel posted a patch to do this for realview and vexpress:
>
> http://lists.infradead.org/pipermail/linux-arm-kernel/2011-December/077014.html
>
> I don't know whether this is currently headed for merge. Without the
> ENDPROC additions in plat-versatile/platsmp.S, taking the BSYM away
> causes breakage. (The missing ENDPROC is the true bug here.)
Pawel, what's the status? I can pick up your patch if it's not queued up.
>
> The changes look sensible, but break realview and vexpress as-is.
> I suggest you coordinate with Pawel and either add the ENDPROC stuff
> into your series, or drop those patches (but then you'll have to wait
> to merge your series, otherwise the removal of the BSYM() macro for
> C code will cause the realview/vexpress code to break).
>
> If you've not already done so, double-check that the target function is
> either C or properly-annotated assembler in each case. However, so far
> as I can see, all the cases are correct, except for realview and
> vexpress.
>
>
> After all these changes, BSYM will only be used in:
>
> boot/compressed/head.S
> include/asm/entry-macro-multi.S
> include/asm/unified.h
> kernel/entry-armv.S
> kernel/entry-common.S
> kernel/head-nommu.S
> kernel/head.S
> kernel/sleep.S
> lib/call_with_stack.S
>
> ... so providing it only for assembler ought to be OK.
>
So is that an ack for the last patch?
Rob
next prev parent reply other threads:[~2012-01-11 15:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 22:45 [PATCH 0/6] BSYM macro removal Rob Herring
2012-01-09 22:45 ` [PATCH 1/6] ARM: exynos: remove incorrect BSYM usage Rob Herring
2012-01-11 15:32 ` Rob Herring
2012-01-09 22:45 ` [PATCH 2/6] ARM: realview: " Rob Herring
2012-01-09 22:45 ` [PATCH 3/6] ARM: vexpress: " Rob Herring
2012-01-10 12:04 ` Dave Martin
2012-01-11 15:19 ` Rob Herring [this message]
2012-01-09 22:45 ` [PATCH 4/6] ARM: imx: " Rob Herring
2012-01-10 3:16 ` Shawn Guo
2012-01-09 22:45 ` [PATCH 5/6] ARM: highbank: " Rob Herring
2012-01-09 22:45 ` [PATCH 6/6] ARM: make BSYM macro assembly only Rob Herring
2012-01-13 14:03 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0DA86F.3020401@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.