Re: [PATCH] ext4: Support "check=none" "nocheck" mount options

[Eric Sandeen <sandeen@redhat.com>]

On 1/11/12 9:26 AM, Ted Ts'o wrote:
> On Wed, Jan 11, 2012 at 09:13:40AM -0600, Eric Sandeen wrote:
>>> In any case, I can't imagine why a user would have this set for a kernel
>>> option that might have last been valid 10 years ago, and why the 5 users
>>> in the world that might have this set cannot simply remove it from their
>>> fstab, since it does absolutely nothing?
>>
>> Well, I agree that it should be deprecated, but that's a separate issue from
>> making ext4 handle all current ext2/3 mount options.
>>
>> Let's just push this one in, and can do another patch to add the dire
>> deprecation warnings to all filesystems, ok?  Then in 5 more years we can
>> remember to remove it ;)
> 
> If we're going to deprecate it, we should deprecate it for *all* of
> the ext 2/3/4 file systems.  Otherwise let's not bother, and keep the
> no-op for backwards compatibility.  If we are going to support ext4
> taking over for ext2/3, then yes we need to support any common mount
> options, and if we want to deprecate a particular option in ext4, we
> should try to deprecate them in ext2/3 as well.

I agree, I'm just saying it can be 2 separate steps; fixing ext4 doesn't
need to wait for deprecating the option on ext2/3.

-Eric

>        	      		     	       	  - Ted