From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Shimoda, Yoshihiro" Date: Thu, 12 Jan 2012 01:54:49 +0000 Subject: Re: [PATCH v4 1/6] dmaengine: shdma: add IRQ resource name definition macros Message-Id: <4F0E3D69.4070003@renesas.com> List-Id: References: <4F0D39E7.4020102@renesas.com> In-Reply-To: <4F0D39E7.4020102@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-sh@vger.kernel.org 2012/01/12 10:04, Paul Mundt wrote: > On Wed, Jan 11, 2012 at 04:27:35PM +0900, Shimoda, Yoshihiro wrote: >> The SH DMAC has an ERROR IRQ and channel IRQs. So, the defination >> macros are used as the resource name, and the resource name will be >> used to detect each IRQ by the driver. >> >> Signed-off-by: Yoshihiro Shimoda >> --- >> about v4: >> - add defination macros for IRQ resource first. >> >> include/linux/sh_dma.h | 4 ++++ >> 1 files changed, 4 insertions(+), 0 deletions(-) >> >> diff --git a/include/linux/sh_dma.h b/include/linux/sh_dma.h >> index cb2dd11..a6c82cc 100644 >> --- a/include/linux/sh_dma.h >> +++ b/include/linux/sh_dma.h >> @@ -13,6 +13,10 @@ >> #include >> #include >> >> +/* resource name of IORESOURCE_IRQ */ >> +#define SH_DMA_IRQ_ERROR "error" >> +#define SH_DMA_IRQ_CHANNEL "channel" >> + > Why? This is just pointless churn, there's nothing wrong with using the > strings open-coded like the vast majority of other drivers/platforms do > without issue. If you can't spell it properly, too bad. > Thank you for your point. I read your comment, I thought that it is good. I am mixed up about the shdma driver patch for the Error IRQ registration... I am thinking that the v3 patches are good because they have Paul's "Acked-by". Best regards, Yoshihiro Shimoda