From: Mike Christie <michaelc@cs.wisc.edu>
To: vikas.chaudhary@qlogic.com
Cc: jbottomley@parallels.com, linux-scsi@vger.kernel.org,
lalit.chandivade@qlogic.com, ravi.anand@qlogic.com,
Karen Higgins <karen.higgins@qlogic.com>
Subject: Re: [PATCH 6/7] qla4xxx: Cleanup modinfo display
Date: Wed, 11 Jan 2012 20:01:20 -0600 [thread overview]
Message-ID: <4F0E3EF0.7030106@cs.wisc.edu> (raw)
In-Reply-To: <1326278661-16368-7-git-send-email-vikas.chaudhary@qlogic.com>
On 01/11/2012 04:44 AM, vikas.chaudhary@qlogic.com wrote:
>
> -int ql4xextended_error_logging = 0; /* 0 = off, 1 = log errors */
> +int ql4xextended_error_logging = 0;
You do not need to init this to 0 like above. It gets set to zero for
you. I think this is some codingstyle doc rule violation. You should run
checkpatch.pl on your patches before sending to catch this type of stuff.
It is probably ok since it was there before and you are not adding it
and your patch is focused on other stuff, but you should clean it up one
day and make note of it for the future.
next prev parent reply other threads:[~2012-01-12 1:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 10:44 [PATCH 0/7] qla4xxx: Update driver version to 5.02.00-k12 vikas.chaudhary
2012-01-11 10:44 ` [PATCH 1/7] qla4xxx: Temperature monitoring for ISP82XX core vikas.chaudhary
2012-01-11 10:44 ` [PATCH 2/7] qla4xxx: Disable generating pause frames in case of FW hung vikas.chaudhary
2012-01-11 10:44 ` [PATCH 3/7] qla4xxx: Added error logging for firmware abort vikas.chaudhary
2012-01-11 10:44 ` [PATCH 4/7] qla4xxx: Clear the RISC interrupt bit during FW init vikas.chaudhary
2012-01-11 10:44 ` [PATCH 5/7] qla4xxx: Update license vikas.chaudhary
2012-01-11 10:44 ` [PATCH 6/7] qla4xxx: Cleanup modinfo display vikas.chaudhary
2012-01-12 2:01 ` Mike Christie [this message]
2012-01-12 12:57 ` Vikas Chaudhary
2012-01-11 10:44 ` [PATCH 7/7] qla4xxx: Update driver version to 5.02.00-k12 vikas.chaudhary
2012-01-12 2:02 ` [PATCH 0/7] " Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0E3EF0.7030106@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=jbottomley@parallels.com \
--cc=karen.higgins@qlogic.com \
--cc=lalit.chandivade@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
--cc=ravi.anand@qlogic.com \
--cc=vikas.chaudhary@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.