Re: [Qemu-devel] [PATCH v6 04/10] ARM: Samsung exynos4210-based boards emulation

[Evgeny Voevodin <e.voevodin@samsung.com>]

On 01/12/2012 12:48 PM, Kyungmin Park wrote:
> On 1/12/12, Evgeny Voevodin<e.voevodin@samsung.com>  wrote:
>> Add initial support of NURI and SMDKC210 boards
>>
>> Signed-off-by: Evgeny Voevodin<e.voevodin@samsung.com>
>> ---
>>   Makefile.target     |    3 +-
>>   hw/exynos4210.c     |  202
>> +++++++++++++++++++++++++++++++++++++++++++++++++++
>>   hw/exynos4210.h     |   37 +++++++++
>>   hw/exynos4_boards.c |  143 ++++++++++++++++++++++++++++++++++++
>>   4 files changed, 384 insertions(+), 1 deletions(-)
>>   create mode 100644 hw/exynos4210.c
>>   create mode 100644 hw/exynos4_boards.c
>>
>> diff --git a/Makefile.target b/Makefile.target
>> index 4ac257e..6199d44 100644
>> --- a/Makefile.target
>> +++ b/Makefile.target
>> @@ -339,7 +339,8 @@ obj-arm-y = integratorcp.o versatilepb.o arm_pic.o
>> arm_timer.o
>>   obj-arm-y += arm_boot.o pl011.o pl031.o pl050.o pl080.o pl110.o pl181.o
>> pl190.o
>>   obj-arm-y += versatile_pci.o
>>   obj-arm-y += realview_gic.o realview.o arm_sysctl.o arm11mpcore.o
>> a9mpcore.o
>> -obj-arm-y += exynos4210_gic.o exynos4210_combiner.o
>> +obj-arm-y += exynos4210_gic.o exynos4210_combiner.o exynos4210.o
>> +obj-arm-y += exynos4_boards.o
>>   obj-arm-y += arm_l2x0.o
>>   obj-arm-y += arm_mptimer.o
>>   obj-arm-y += armv7m.o armv7m_nvic.o stellaris.o pl022.o stellaris_enet.o
>> diff --git a/hw/exynos4210.c b/hw/exynos4210.c
>> new file mode 100644
>> index 0000000..82755db
>> --- /dev/null
>> +++ b/hw/exynos4210.c
>> @@ -0,0 +1,202 @@
>> +/*
>> + *  Samsung exynos4210 SoC emulation
>> + *
>> + *  Copyright (c) 2011 Samsung Electronics Co., Ltd. All rights reserved.
>> + *    Maksim Kozlov<m.kozlov@samsung.com>
>> + *    Evgeny Voevodin<e.voevodin@samsung.com>
>> + *    Igor Mitsyanko<i.mitsyanko@samsung.com>
>> + *
>> + *  This program is free software; you can redistribute it and/or modify it
>> + *  under the terms of the GNU General Public License as published by the
>> + *  Free Software Foundation; either version 2 of the License, or
>> + *  (at your option) any later version.
>> + *
>> + *  This program is distributed in the hope that it will be useful, but
>> WITHOUT
>> + *  ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
>> + *  FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
>> + *  for more details.
>> + *
>> + *  You should have received a copy of the GNU General Public License along
>> + *  with this program; if not, see<http://www.gnu.org/licenses/>.
>> + *
>> + */
>> +
>> +#include "boards.h"
>> +#include "sysemu.h"
>> +#include "sysbus.h"
>> +#include "arm-misc.h"
>> +#include "exynos4210.h"
>> +
>> +#define EXYNOS4210_CHIPID_ADDR         0x10000000
>> +
>> +/* External GIC */
>> +#define EXYNOS4210_EXT_GIC_CPU_BASE_ADDR    0x10480000
>> +#define EXYNOS4210_EXT_GIC_DIST_BASE_ADDR   0x10490000
>> +
>> +/* Combiner */
>> +#define EXYNOS4210_EXT_COMBINER_BASE_ADDR   0x10440000
>> +#define EXYNOS4210_INT_COMBINER_BASE_ADDR   0x10448000
> FYI: Even though there's internal combiner, it doesn't used any more.
> and there's no codes at kernel.
>

Kernel v3.0 uses it. And I think that if HW contains one, it shouldn't 
be removed from emulation.

-- 
Kind regards,
Evgeny Voevodin,
Leading Software Engineer,
ASWG, Moscow R&D center, Samsung Electronics
e-mail: e.voevodin@samsung.com