From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: NeilBrown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org, dledford@redhat.com
Subject: Re: [PATCH 1/1] Work around gcc-4.7's strict aliasing checks
Date: Thu, 12 Jan 2012 10:24:51 +0100 [thread overview]
Message-ID: <4F0EA6E3.8010705@redhat.com> (raw)
In-Reply-To: <20120112104320.471910db@notabene.brown>
On 01/12/12 00:43, NeilBrown wrote:
> Applied - thanks...
>
> Do you understand this stuff? If this really "fixing" anything, or is it
> still doing something bad, but is now hiding it from gcc's warning so we just
> don't get told how naughty we are?
>
> Should these things be changed to use unions ??
I have to admit that I didn't want to touch the functionality. It was
basically the sha code which is sensitive to changes, and I don't
understand the algorithm, and the ddf metadata which I have no way of
testing, so I opted for functionality rather than risking breaking
someone's data.
Cheers,
Jes
next prev parent reply other threads:[~2012-01-12 9:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 11:16 [PATCH 0/1] gcc-4.7 build fix Jes.Sorensen
2012-01-05 11:16 ` [PATCH 1/1] Work around gcc-4.7's strict aliasing checks Jes.Sorensen
2012-01-11 23:43 ` NeilBrown
2012-01-12 7:14 ` David Brown
2012-01-12 13:45 ` Michal Soltys
2012-01-13 12:20 ` David Brown
2012-01-13 14:21 ` Michal Soltys
2012-01-13 17:48 ` David Brown
2012-01-12 9:24 ` Jes Sorensen [this message]
2012-01-22 0:49 ` Michal Soltys
2012-01-22 0:49 ` [PATCH] compile cleanly with -Wstrict-aliasing=1 Michal Soltys
2012-01-23 12:50 ` [PATCH 1/1] Work around gcc-4.7's strict aliasing checks Jes Sorensen
2012-01-24 0:59 ` Michal Soltys
2012-01-24 9:18 ` David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0EA6E3.8010705@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=dledford@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.