All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Simek <monstr@monstr.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v7] net: ll_temac: Add LL TEMAC driver to u-boot
Date: Thu, 12 Jan 2012 11:53:18 +0100	[thread overview]
Message-ID: <4F0EBB9E.2040609@monstr.eu> (raw)
In-Reply-To: <20120111160704.C82141167AAC@gemini.denx.de>

Wolfgang Denk wrote:
> Dear Stephan Linz,
> 
> In message <1325956366.18981.47.camel@keto> you wrote:
>> I'll provide the same way for the Xilinx LL_TEMAC driver as for the
>> Xilinx AXI-EMAC driver. I prepare the microblaze-generic board code to
>> support all potential Ethernet drivers but leave out the specific usage.
>> You are right when you say that there is no code that refere to the new
>> driver code -- there are also no configuration for this. And yes we
>> adapt/change the xparameters.h out of mainline tree to enable the driver
>> code -- but I think, that is not really a "out of tree port".
>>
>> But what would be the best implementation for unspecified targets here?
> 
> The question is actually a very simple one here: is there any board
> configuration in mainline that will actually compile and link against
> this driver?  If yes, then everything is fine.  If not, we would not
> even know if there were gross syntax errors in that code, and we would
> never notce when changes to other parts break compatibility with it.
> 
> This is why I will not add any code that is not used in mainline -
> out-of-tree users don't help a bit.

OK. Stephan, please send v8 with suggested changes with all patches or link to patches which are necessary
to use.
Please also define fake address XILINX_LLTEMAC_BASEADDR in xparameters.h to be compiled.
The same we will do for axi emac driver.

Stephan if you like I can add that changes to my custodian git tree and do final testing
before we ask Wolfgang to merge.

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian

  reply	other threads:[~2012-01-12 10:53 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-01 20:39 [U-Boot] LL TEMAC V7 refactored Stephan Linz
2011-12-01 20:39 ` [U-Boot] [PATCH v7] net: ll_temac: Add LL TEMAC driver to u-boot Stephan Linz
2011-12-20 22:56   ` Wolfgang Denk
2011-12-21 19:22     ` Stephan Linz
2011-12-21 19:28     ` [U-Boot] [PATCH 1/3] microblaze: Enable several ethernet driver compilation Stephan Linz
2011-12-21 19:28     ` [U-Boot] [PATCH 2/3] microblaze: Enable phylib and mii support Stephan Linz
2011-12-21 19:28     ` [U-Boot] [PATCH 3/3] microblaze: Wire up LL_TEMAC driver initialization Stephan Linz
2011-12-22  9:02     ` [U-Boot] [PATCH v7] net: ll_temac: Add LL TEMAC driver to u-boot Michal Simek
2012-01-05 16:10       ` Wolfgang Denk
2012-01-05 17:11         ` Stephan Linz
2012-01-05 19:19           ` Wolfgang Denk
2012-01-07 17:12             ` Stephan Linz
2012-01-11 12:05               ` Michal Simek
2012-01-11 16:07               ` Wolfgang Denk
2012-01-12 10:53                 ` Michal Simek [this message]
2012-01-12 16:05                   ` Stephan Linz
2011-12-29 17:57   ` Andy Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F0EBB9E.2040609@monstr.eu \
    --to=monstr@monstr.eu \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.