Re: [PATCH] irqdomain: include linux/bug.h for WARN_ON()

[Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

Jamie,

On 12/19/2011 04:22 PM, Jamie Iles wrote:
> Commit 6d274309d (irq: support domains with non-zero hwirq base)
> introduced a WARN_ON() for an invalid hwirq in irq_domain_to_irq() but
> doesn't include linux/bug.h resulting in:
> 
> include/linux/irqdomain.h: In function 'irq_domain_to_irq':
> include/linux/irqdomain.h:78:2: error: implicit declaration of function 'WARN_ON'
> 
> if it isn't implicitly pulled in before.
> 

Considering major irqdomain changes are coming, is this really needed?
Nothing is currently broken, right?

Rob

> Cc: Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>
> Cc: Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>
> Cc: Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
> Signed-off-by: Jamie Iles <jamie-wmLquQDDieKakBO8gow8eQ@public.gmane.org>
> ---
>  include/linux/irqdomain.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/irqdomain.h b/include/linux/irqdomain.h
> index fd9815b..0c17b4b 100644
> --- a/include/linux/irqdomain.h
> +++ b/include/linux/irqdomain.h
> @@ -15,6 +15,7 @@
>  #ifndef _LINUX_IRQDOMAIN_H
>  #define _LINUX_IRQDOMAIN_H
>  
> +#include <linux/bug.h>
>  #include <linux/mod_devicetable.h>
>  
>  #ifdef CONFIG_IRQ_DOMAIN