From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Retanubun Subject: [i2c-mpc.c] adding entry for mpc8360 Date: Thu, 12 Jan 2012 10:34:16 -0500 Message-ID: <4F0EFD78.3020708@ruggedcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: wg-ynQEQJNshbs@public.gmane.org Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org Hello, I am wondering if it is okay to add .compatible entries for mpc8360 and declare its data structure to mpc-i2c.c something like this: {.compatible = "fsl,mpc8360-i2c", .data = &mpc_i2c_data_8360, }, static struct mpc_i2c_data mpc_i2c_data_8360 __devinitdata = { .setup = mpc_i2c_setup_8xxx, }; or is the intended approach to match the closest thing to your CPU (in this case mpc8313) ? -- Richard Retanubun