From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlNrL-0006G6-Cc for qemu-devel@nongnu.org; Thu, 12 Jan 2012 11:50:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RlNrB-0004eV-3E for qemu-devel@nongnu.org; Thu, 12 Jan 2012 11:50:39 -0500 Received: from thoth.sbs.de ([192.35.17.2]:25434) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlNrA-0004dk-N7 for qemu-devel@nongnu.org; Thu, 12 Jan 2012 11:50:29 -0500 Message-ID: <4F0F0F50.6030706@siemens.com> Date: Thu, 12 Jan 2012 17:50:24 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1326385868-26538-1-git-send-email-hdegoede@redhat.com> In-Reply-To: <1326385868-26538-1-git-send-email-hdegoede@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] usb-redir: Add the posibility to filter out certain devices from redirecion List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hans de Goede Cc: Gerd Hoffmann , qemu-devel@nongnu.org On 2012-01-12 17:31, Hans de Goede wrote: > This patch adds the posibility to filter out certain devices from redirecion. > To use this pass the filter property to -device usb-redir. The filter > property takes a string consisting of filter rules, the format for a rule is: > :::: > > -1 can be used to allow any value for a field. > > Muliple rules can be concatonated using | as a separator. Note that if > a device matches none of the passed in rules, redirecting it will not be > allowed! > Hmm, '|' makes quoting mandatory. And the : is also not that beautiful IMHO. What about [+]|-:::[/[+]|-:...] ? Optional '+' means allow, '-' disallow. An empty field could also serve as wildcard (instead of explicit -1 which would collide with disallow). Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux