From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41627) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlPYp-0006Pr-3N for qemu-devel@nongnu.org; Thu, 12 Jan 2012 13:39:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RlPYk-000738-OS for qemu-devel@nongnu.org; Thu, 12 Jan 2012 13:39:39 -0500 Message-ID: <4F0F287B.3010009@suse.de> Date: Thu, 12 Jan 2012 19:37:47 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <4F0487EE.6090502@suse.de> <4F09C4E9.3010300@suse.de> In-Reply-To: <4F09C4E9.3010300@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] hw/vmmouse.c: Fix to disable vmmouse after reboot List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerhard Wiesinger Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org Am 08.01.2012 17:31, schrieb Andreas F=E4rber: > Am 08.01.2012 13:01, schrieb Gerhard Wiesinger: >> On Wed, 4 Jan 2012, Gerhard Wiesinger wrote: >> >>> Testscenario: >>> 1.) Boot e.g. OS with VMMouse support (e.g. Windows) >>> 2.) reboot >>> 3.) Boot e.g. OS without VMMouse support (e.g. DOS) =3D> PS/2 mouse >>> doesn't work any more. Fixes that issue. >>> >>> Reason is that VMMouse has priority and disables all other mouse >>> entities and therefore must be disabled on reset. >> >> Any further comments before integrating the patch? >=20 > I implicitly asked you for a more verbose commit message. >=20 > For example, based on the info you provided as a reply above: >=20 > --8<-- > hw/vmmouse.c: Disable vmmouse on reboot >=20 > When a guest activated the vmmouse, following a reboot the vmmouse > stayed enabled and the PS/2 mouse was unusable. That way, when rebootin= g > to guests without vmmouse support the mouse would not work. >=20 > Fix this by disabling the vmmouse in its reset handler. > --8<-- I have been unable to reproduce this issue with our qemu-kvm 0.15.1. SLES 11 uses vmmouse, whereas SLES installation does not use vmmouse. After doing a kdump or reboot in SLES, the mouse worked just fine in either of them. The patch doesn't break anything for me though. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg