From: KOSAKI Motohiro <kosaki.motohiro@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Mel Gorman <mgorman@suse.de>, Christoph Lameter <cl@linux.com>,
Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [RFC][PATCH] mm: Remove NUMA_INTERLEAVE_HIT
Date: Thu, 12 Jan 2012 14:02:50 -0500 [thread overview]
Message-ID: <4F0F2E5A.3070602@gmail.com> (raw)
In-Reply-To: <20120112182644.GE11715@one.firstfloor.org>
(1/12/12 1:26 PM), Andi Kleen wrote:
> On Thu, Jan 12, 2012 at 04:07:00PM +0100, Peter Zijlstra wrote:
>> Since the NUMA_INTERLEAVE_HIT statistic is useless on its own; it wants
>> to be compared to either a total of interleave allocations or to a miss
>> count, remove it.
>
> Nack!
>
> This would break the numactl testsuite.
This seems slightly strange reason to me. Almost useless/deprecated feature removement broke ltp testsuite. But endusers never complained. Because they never use testcases for development. So, May I clarify your intention? To use Documention/feature-removal-schedule.txt solve your worry?
Personally, I haven't observed NUMA_INTERLEAVE_HIT is used on production environment. But, I also haven't
felt this feature is a code maintenance bottleneck. So, I'd like to just ask.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-01-12 19:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 15:07 [RFC][PATCH] mm: Remove NUMA_INTERLEAVE_HIT Peter Zijlstra
2012-01-12 17:37 ` Christoph Lameter
2012-01-12 18:26 ` Andi Kleen
2012-01-12 19:02 ` KOSAKI Motohiro [this message]
2012-01-12 19:10 ` Andi Kleen
2012-01-12 20:13 ` Peter Zijlstra
2012-01-12 21:07 ` Andi Kleen
2012-01-12 21:40 ` Andrew Morton
2012-01-12 22:29 ` Andi Kleen
2012-01-13 15:28 ` Christoph Lameter
2012-01-13 18:39 ` Andi Kleen
2012-01-13 19:28 ` Christoph Lameter
2012-05-18 10:22 ` [tip:sched/numa] mm/mpol: " tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0F2E5A.3070602@gmail.com \
--to=kosaki.motohiro@gmail.com \
--cc=Lee.Schermerhorn@hp.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=cl@linux.com \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.