From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Greear <greearb@candelatech.com>
Date: Thu, 12 Jan 2012 12:34:06 -0800
Subject: [ath9k-devel] Question on keycache size.
In-Reply-To: <4F0F3F0B.1010101@candelatech.com>
References: <4F0E0537.2000509@candelatech.com>
	<CAD2nsn22jxbvbhcgQX8q6Y+b543yRi4SNsB9Ynr5dFONQmFQow@mail.gmail.com>
	<4F0F041F.4020300@candelatech.com>
	<CAJ-VmomRZ5CoJdXHG5ngb56tC_XHwm2Cackg36n8s=H-QrC3Aw@mail.gmail.com>
	<4F0F3F0B.1010101@candelatech.com>
Message-ID: <4F0F43BE.3080108@candelatech.com>
List-Id: <ath9k-devel.lists.ath9k.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ath9k-devel@lists.ath9k.org

Here's a bit that looks questionable to me.  This is from
ath9k_rx_skb_postprocess

I'm thinking maybe that else clause should not re-assign
keyix if keyix is RXKEYIX_INVALID (and never set the RX_FLAG_DECRYPTED
flag in rxs->flag?

	if (!(keyix == ATH9K_RXKEYIX_INVALID) && !decrypt_error &&
	    ieee80211_has_protected(fc)) {
		rxs->flag |= RX_FLAG_DECRYPTED;
	} else if (ieee80211_has_protected(fc)
		   && !decrypt_error && skb->len >= hdrlen + 4) {
		keyix = skb->data[hdrlen + 3] >> 6;

		if (test_bit(keyix, common->keymap))
			rxs->flag |= RX_FLAG_DECRYPTED;
	}

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com