From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takuya Yoshikawa Subject: Re: [PATCH] KVM: MMU: increment stats after event occurrence Date: Fri, 13 Jan 2012 10:24:14 +0900 Message-ID: <4F0F87BE.2020202@oss.ntt.co.jp> References: <1326416880.3416.2.camel@offbook> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Marcelo Tosatti , Xiao Guangrong , lkml , kvm@vger.kernel.org To: dave@gnu.org Return-path: Received: from serv2.oss.ntt.co.jp ([222.151.198.100]:48377 "EHLO serv2.oss.ntt.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755707Ab2AMBW5 (ORCPT ); Thu, 12 Jan 2012 20:22:57 -0500 In-Reply-To: <1326416880.3416.2.camel@offbook> Sender: kvm-owner@vger.kernel.org List-ID: (2012/01/13 10:08), Davidlohr Bueso wrote: > From: Davidlohr Bueso > > It makes more sense to actually increment statistics for tlb flushes and page table entry updates after such _events_ occur, instead of before. Why? Takuya > > Signed-off-by: Davidlohr Bueso > --- > arch/x86/kvm/mmu.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c > index 2a2a9b4..0b7008e 100644 > --- a/arch/x86/kvm/mmu.c > +++ b/arch/x86/kvm/mmu.c > @@ -3130,8 +3130,8 @@ static int nonpaging_init_context(struct kvm_vcpu *vcpu, > > void kvm_mmu_flush_tlb(struct kvm_vcpu *vcpu) > { > - ++vcpu->stat.tlb_flush; > kvm_make_request(KVM_REQ_TLB_FLUSH, vcpu); > + ++vcpu->stat.tlb_flush; > } > > static void paging_new_cr3(struct kvm_vcpu *vcpu) > @@ -3486,8 +3486,8 @@ static void mmu_pte_write_new_pte(struct kvm_vcpu *vcpu, > return; > } > > - ++vcpu->kvm->stat.mmu_pte_updated; > vcpu->arch.mmu.update_pte(vcpu, sp, spte, new); > + ++vcpu->kvm->stat.mmu_pte_updated; > } > > static bool need_remote_flush(u64 old, u64 new)