From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Babic <sbabic@denx.de>
Date: Fri, 13 Jan 2012 09:32:42 +0100
Subject: [U-Boot] [PATCH 2/2] tt01: add MMC support
In-Reply-To: <1326290363-4767-3-git-send-email-helmut.raiger@hale.at>
References: <4EC0F392.60000@denx.de>
	<1326290363-4767-1-git-send-email-helmut.raiger@hale.at>
	<1326290363-4767-3-git-send-email-helmut.raiger@hale.at>
Message-ID: <4F0FEC2A.8010709@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 11/01/2012 14:59, Helmut Raiger wrote:
> board_mmc_init() initializes the pins of SDHC1 and
> turns on V_MMC1 of the PMIC. Config adds support for EXT2
> and FAT.
> 
> Signed-off-by: Helmut Raiger <helmut.raiger@hale.at>
> ---

Hi Helmut,

> +
> +	/* turn on power V_MMC1, bit 18 is the VMMC1 enable */
> +	if (pmic_reg_read(p, 33, &val) < 0)

Sure do we have not constants to be used insstead of fixed values ? If
not, can you add such constants ?

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office@denx.de
=====================================================================