From: Dmitry Antipov <dmitry.antipov@linaro.org>
To: Aaro Koskinen <aaro.koskinen@nokia.com>
Cc: linaro-dev@lists.linaro.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: use usleep_range() in mmc_delay()
Date: Fri, 13 Jan 2012 17:51:09 +0400 [thread overview]
Message-ID: <4F1036CD.3090608@linaro.org> (raw)
In-Reply-To: <alpine.DEB.2.00.1201131514490.31704@kernel.research.nokia.com>
On 01/13/2012 05:22 PM, Aaro Koskinen wrote:
> Anyway, I think the change is good. On systems with multiple MMC devices
> the boot/probe can spend 100-200 ms alone just doing busylooping delays. I
> think e.g. in mmc_rescan() the code uses frequently mmc_delay(10).
I'm worrying about this:
mmc_delay(DIV_ROUND_UP(card->ext_csd.sa_timeout, 10000))
since I have no ideas about typical values for this timeout.
If it may be too small (<=10 us), using usleep_range() makes no sense.
Dmitry
next prev parent reply other threads:[~2012-01-13 13:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 6:56 [PATCH] mmc: use usleep_range() in mmc_delay() Dmitry Antipov
2011-12-21 11:25 ` Sujit Reddy Thumma
2011-12-21 13:05 ` Dmitry Antipov
2011-12-27 4:40 ` Sujit Reddy Thumma
2012-01-13 13:22 ` Aaro Koskinen
2012-01-13 13:51 ` Dmitry Antipov [this message]
2012-01-13 14:52 ` Aaro Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1036CD.3090608@linaro.org \
--to=dmitry.antipov@linaro.org \
--cc=aaro.koskinen@nokia.com \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.