From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:60417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RlkG3-0002fM-6d for qemu-devel@nongnu.org; Fri, 13 Jan 2012 11:45:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RlkFx-0000E6-HE for qemu-devel@nongnu.org; Fri, 13 Jan 2012 11:45:39 -0500 Message-ID: <4F105FA9.1040108@siemens.com> Date: Fri, 13 Jan 2012 17:45:29 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1325894809-17322-1-git-send-email-andreas.faerber@web.de> <1326424168-15705-1-git-send-email-andreas.faerber@web.de> <1326424168-15705-9-git-send-email-andreas.faerber@web.de> <4F0FF7AD.2080403@siemens.com> <4F10544E.6050501@web.de> <4F1056ED.908@siemens.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v3 8/8] prep: Use i82378 PCI->ISA bridge for 'prep' machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: =?ISO-8859-1?Q?Herv=E9_Po?= =?ISO-8859-1?Q?ussineau?= , =?ISO-8859-1?Q?Andreas_F=E4rber?= , "qemu-ppc@nongnu.org" , "qemu-devel@nongnu.org" On 2012-01-13 17:23, Alexander Graf wrote: >=20 > On 13.01.2012, at 17:08, Jan Kiszka wrote: >=20 >> On 2012-01-13 16:57, Andreas F=E4rber wrote: >>> Am 13.01.2012 10:21, schrieb Jan Kiszka: >>>> On 2012-01-13 04:09, Andreas F=E4rber wrote: >>>>> + isa_bus =3D DO_UPCAST(ISABus, qbus, qdev_get_child_bus(&pci->q= dev, "isa.0")); >>>>> + >>>>> + i8259 =3D isa_bus->irqs; >>>> >>>> I think this is unneeded. >>> >>> The problem here was that isa_get_irq() needs an ISADevice*, not just >>> the ISABus*, so I had to access ->irqs directly at this point. >> >> Which is a hack that should not be merged. >> >>> >>> Some of the later ISA devices are optional, others will be moved to t= he >>> pc87312. The i8042 might be an option if we really have to. >>> >>>> You only access i8259[8] later on for >>>> initializing the m48t59. >>> >>> And immediately following your quote i8259[9] and i8259[11] for the h= ost >>> bridge. >> >> I was looking at upstream. Which patch is this? >=20 > The patch you were commenting on :) I see now. It just doesn't introduce it. :) OK, so the problem is that the creator of the PIC does not export the input IRQs in a way that they can be used by non-ISA chipset-external devices as well. It's that fixable? Via GPIO pins of the chipset e.g.? Jan --=20 Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux