All of lore.kernel.org
 help / color / mirror / Atom feed
From: rmallon@gmail.com (Ryan Mallon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/11] ep93xx: Make syscon access functions private to SoC
Date: Sat, 14 Jan 2012 08:43:01 +1100	[thread overview]
Message-ID: <4F10A565.9060907@gmail.com> (raw)
In-Reply-To: <ADE657CA350FB648AAC2C43247A983F001F3F99EBB05@AUSP01VMBX24.collaborationhost.net>

On 14/01/12 04:38, H Hartley Sweeten wrote:
> On Tuesday, January 10, 2012 8:15 PM, Ryan Mallon wrote:
>> The syscon access functions are no longer used outside of the
>> core EP93xx code. Move their definitions into the SoC code.
>>
>> Cc: Hartley Sweeten <hsweeten@visionengravers.com>
>> Cc: Mika Westerberg <mika.westerberg@iki.fi>
>> Signed-off-by: Ryan Mallon <rmallon@gmail.com>
>> ---
>>  arch/arm/mach-ep93xx/clock.c                 |    1 +
>>  arch/arm/mach-ep93xx/core.c                  |    2 --
>>  arch/arm/mach-ep93xx/include/mach/platform.h |   14 --------------
>>  arch/arm/mach-ep93xx/soc.h                   |   14 ++++++++++++++
>>  4 files changed, 15 insertions(+), 16 deletions(-)
> It looks like part of this patch is word wrapped, or it could just be me...

Odd, not sure what happened there. The code I have looks correct, and it
was sent using git format-patch/send-email.

> <snip>
>
>> diff --git a/arch/arm/mach-ep93xx/soc.h b/arch/arm/mach-ep93xx/soc.h index b0ef89b..958282a 100644
>> --- a/arch/arm/mach-ep93xx/soc.h
>> +++ b/arch/arm/mach-ep93xx/soc.h
>> @@ -13,6 +13,20 @@
>>  #ifndef _EP93XX_SOC_H
>>  #define _EP93XX_SOC_H
>>  
>> +/* EP93xx System Controller software locked register write */ void 
>> +ep93xx_syscon_swlocked_write(unsigned int val, void __iomem *reg); void 
>> +ep93xx_devcfg_set_clear(unsigned int set_bits, unsigned int 
>> +clear_bits);
>> +
>> +static inline void ep93xx_devcfg_set_bits(unsigned int bits) {
>> +	ep93xx_devcfg_set_clear(bits, 0x00);
>> +}
>> +
>> +static inline void ep93xx_devcfg_clear_bits(unsigned int bits) {
>> +	ep93xx_devcfg_set_clear(0x00, bits);
>> +}
>> +
>>  /*
>>   * EP93xx Physical Memory Map:
>>   *
> I would prefer these functions to be after all the #define's.  But, your call...
>
> Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>
I'll move them.

Thanks,
~Ryan

  reply	other threads:[~2012-01-13 21:43 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-11  3:14 [PATCH 00/11] ep93xx: Move SoC private bits to core Ryan Mallon
2012-01-11  3:14 ` [PATCH 01/11] ep93xx: Move PHYS_BASE defines to local SoC header file Ryan Mallon
2012-01-13 17:18   ` H Hartley Sweeten
2012-01-13 21:35     ` Ryan Mallon
2012-01-11  3:14 ` [PATCH 02/11] ep93xx: Move GPIO defines to gpio-ep93xx.h Ryan Mallon
2012-01-13 17:22   ` H Hartley Sweeten
2012-01-11  3:14 ` [PATCH 03/11] ep93xx: Move peripheral defines to local SoC header Ryan Mallon
2012-01-13 17:25   ` H Hartley Sweeten
2012-01-11  3:14 ` [PATCH 04/11] ep93xx: Configure GPIO ports in core code Ryan Mallon
2012-01-13  6:27   ` Mika Westerberg
2012-01-13  7:00     ` Ryan Mallon
2012-01-13  8:12       ` Mika Westerberg
2012-01-13 18:05       ` H Hartley Sweeten
2012-01-11  3:14 ` [PATCH 05/11] ep93xx: Move arch_reset to core.c Ryan Mallon
2012-01-13 17:28   ` H Hartley Sweeten
2012-01-11  3:14 ` [PATCH 06/11] ep93xx: Don't use system controller defines in audio drivers Ryan Mallon
2012-01-11 17:42   ` Mark Brown
2012-01-11 19:57     ` Ryan Mallon
2012-01-12  3:04       ` Mark Brown
2012-01-13 17:35   ` H Hartley Sweeten
2012-01-13 21:41     ` Ryan Mallon
2012-01-13 22:13       ` Mark Brown
2012-01-11  3:14 ` [PATCH 07/11] ep93xx: Make syscon access functions private to SoC Ryan Mallon
2012-01-13 17:38   ` H Hartley Sweeten
2012-01-13 21:43     ` Ryan Mallon [this message]
2012-01-11  3:14 ` [PATCH 08/11] ep93xx: Move EP93XX_WATCHDOG_BASE define to driver Ryan Mallon
2012-01-13 17:45   ` H Hartley Sweeten
2012-01-13 21:46     ` Ryan Mallon
2012-01-13 22:48       ` H Hartley Sweeten
2012-01-11  3:14 ` [PATCH 09/11] ep93xx: Move crunch code to mach-ep93xx directory Ryan Mallon
2012-01-13 17:51   ` H Hartley Sweeten
2012-01-13 21:16     ` Ryan Mallon
2012-01-13 21:52       ` Russell King - ARM Linux
2012-01-11  3:14 ` [PATCH 10/11] ep93xx: Move EP93XX_SYSCON defines to SoC private header Ryan Mallon
2012-01-13 17:52   ` H Hartley Sweeten
2012-01-11  3:14 ` [PATCH 11/11] ep93xx: Remove unnecessary includes of ep93xx-regs.h Ryan Mallon
2012-01-13 17:54   ` H Hartley Sweeten
2012-01-12  0:17 ` [PATCH 00/11] ep93xx: Move SoC private bits to core Ryan Mallon
2012-01-13 17:56 ` H Hartley Sweeten
2012-01-14 19:07 ` Mika Westerberg
2012-01-16  4:51   ` Ryan Mallon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F10A565.9060907@gmail.com \
    --to=rmallon@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.