All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/2] fdt: Add tests for fdtdec
Date: Fri, 13 Jan 2012 14:49:50 -0700	[thread overview]
Message-ID: <4F10A6FE.20308@nvidia.com> (raw)
In-Reply-To: <1326323284-29263-3-git-send-email-sjg@chromium.org>

On 01/11/2012 04:08 PM, Simon Glass wrote:
> The fdtdec_find_aliases_for_id() function is complicated enough that
> it really should have some tests. This does not necessarily need to be
> committed to U-Boot, but it might be useful.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>

> +static int run_test(const char *aliases, const char *nodes, const char *expect)
...
> +	va_list ptr;
...
> +	va_end(ptr);

ptr doesn't seem to be used, and this isn't a varargs function.

Otherwise,

Acked-by: Stephen Warren <swarren@nvidia.com>

-- 
nvpublic

  reply	other threads:[~2012-01-13 21:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-11 23:08 [U-Boot] [PATCH v2 0/2] fdt: Deal correctly with alias nodes Simon Glass
2012-01-11 23:08 ` [U-Boot] [PATCH v2 1/2] fdt: Add fdtdec_find_aliases() to deal " Simon Glass
2012-01-13 21:41   ` Stephen Warren
2012-01-17 18:19     ` Simon Glass
2012-01-11 23:08 ` [U-Boot] [PATCH v2 2/2] fdt: Add tests for fdtdec Simon Glass
2012-01-13 21:49   ` Stephen Warren [this message]
2012-01-17 18:17     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F10A6FE.20308@nvidia.com \
    --to=swarren@nvidia.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.