All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthias Fuchs <matthias.fuchs@esd.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx28: fix i.MX28 spi driver
Date: Sat, 14 Jan 2012 21:09:12 +0100	[thread overview]
Message-ID: <4F11E0E8.8070801@esd.eu> (raw)
In-Reply-To: <CAOMZO5B5z6urOb7jx83c46tG_3V2TZ9LjpPJ9iVbDF9w-pEMzg@mail.gmail.com>

This cannot work. I do not understand what you are trying to achieve with this.

Matthias

On 01/14/2012 07:54 PM, Fabio Estevam wrote:
> On Sat, Jan 14, 2012 at 4:53 PM, Fabio Estevam <festevam@gmail.com> wrote:
> 
>> Actually I meant this:
> 
> One more time ;-)
> 
> --- a/drivers/spi/mxs_spi.c
> +++ b/drivers/spi/mxs_spi.c
> @@ -130,13 +130,10 @@ int spi_xfer(struct spi_slave *slave, unsigned int bitlen,
>         const char *tx = dout;
>         char *rx = din;
> 
> -       if (bitlen == 0)
> -               return 0;
> -
>         if (!rx && !tx)
>                 return 0;
> 
> -       if (flags & SPI_XFER_BEGIN)
> +       if ((flags & SPI_XFER_BEGIN) && len)
>                 mxs_spi_start_xfer(ssp_regs);
> 
>         while (len--) {
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

  reply	other threads:[~2012-01-14 20:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-14 12:25 [U-Boot] [PATCH] mx28: fix i.MX28 spi driver Matthias Fuchs
2012-01-14 14:10 ` Marek Vasut
2012-01-14 18:37   ` Matthias Fuchs
2012-01-16 23:33     ` Alexander Keller
2012-01-17 19:34       ` Fabio Estevam
2012-01-14 18:46 ` Fabio Estevam
2012-01-14 18:53   ` Fabio Estevam
2012-01-14 18:54     ` Fabio Estevam
2012-01-14 20:09       ` Matthias Fuchs [this message]
2012-01-14 20:14         ` Fabio Estevam
2012-01-15 12:10           ` Matthias Fuchs
2012-01-15 15:28             ` Fabio Estevam
2012-01-15 18:36               ` Matthias Fuchs
2012-01-23 19:52 ` Fabio Estevam
2012-01-23 19:53   ` Marek Vasut
2012-01-24  8:40 ` Stefano Babic
2012-01-28 22:08   ` Fabio Estevam
2012-01-29  9:12     ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F11E0E8.8070801@esd.eu \
    --to=matthias.fuchs@esd.eu \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.