From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Antti Palosaari <crope@iki.fi>
Cc: linux-media <linux-media@vger.kernel.org>,
Patrick Boettcher <pboettcher@kernellabs.com>,
Andreas Oberritter <obi@linuxtv.org>
Subject: Re: [PATCH RFCv2] add DTMB support for DVB API
Date: Sat, 14 Jan 2012 20:30:01 -0200 [thread overview]
Message-ID: <4F1201E9.3090402@redhat.com> (raw)
In-Reply-To: <4F11A0B3.9000102@iki.fi>
Em 14-01-2012 13:35, Antti Palosaari escreveu:
> On 01/14/2012 05:31 PM, Antti Palosaari wrote:
>> +typedef enum fe_interleaving {
>> + INTERLEAVING_NONE,
>> + INTERLEAVING_240,
>> + INTERLEAVING_720,
>> +} fe_interleaving_t;
>
> Checkpatch didn't like that, but I left it as all the others are similar. I am happy to fix it too if there is idea what it should be.
>
> WARNING: do not add new typedefs
> #165: FILE: include/linux/dvb/frontend.h:225:
> +typedef enum fe_interleaving {
Just use:
enum fe_interleaving {
...
};
having a typedef here won't help at all, as the DVBv5 API uses "u32" for
the types. So, a typecast will happen anyway every time this is used.
Regards,
Mauro.
next prev parent reply other threads:[~2012-01-14 22:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-14 15:31 [PATCH RFCv2] add DTMB support for DVB API Antti Palosaari
2012-01-14 15:35 ` Antti Palosaari
2012-01-14 22:30 ` Mauro Carvalho Chehab [this message]
2012-01-16 16:44 ` Patrick Boettcher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1201E9.3090402@redhat.com \
--to=mchehab@redhat.com \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=obi@linuxtv.org \
--cc=pboettcher@kernellabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.