From: Avi Kivity <avi@redhat.com>
To: dave@gnu.org
Cc: Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp>,
Marcelo Tosatti <mtosatti@redhat.com>,
Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>,
lkml <linux-kernel@vger.kernel.org>,
kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: MMU: increment stats after event occurrence
Date: Sun, 15 Jan 2012 16:04:10 +0200 [thread overview]
Message-ID: <4F12DCDA.7040706@redhat.com> (raw)
In-Reply-To: <1326459360.3231.3.camel@offbook>
On 01/13/2012 02:56 PM, Davidlohr Bueso wrote:
> On Fri, 2012-01-13 at 10:24 +0900, Takuya Yoshikawa wrote:
> > (2012/01/13 10:08), Davidlohr Bueso wrote:
> > > From: Davidlohr Bueso<dave@gnu.org>
> > >
> > > It makes more sense to actually increment statistics for tlb flushes and page table entry updates after such _events_ occur, instead of before.
> >
> > Why?
> >
> From a logical point of view its better to increase stats once the event
> is processed - usually because it can fail and therefore the stats would
> be incorrect.
>
That doesn't hold for the cases you change.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2012-01-15 14:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 1:08 [PATCH] KVM: MMU: increment stats after event occurrence Davidlohr Bueso
2012-01-13 1:24 ` Takuya Yoshikawa
2012-01-13 12:56 ` Davidlohr Bueso
2012-01-15 14:04 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F12DCDA.7040706@redhat.com \
--to=avi@redhat.com \
--cc=dave@gnu.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.