All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL] Fix for kvm dirty logging
Date: Sun, 15 Jan 2012 10:23:22 -0600	[thread overview]
Message-ID: <4F12FD7A.1010301@codemonkey.ws> (raw)
In-Reply-To: <4F12E473.9080700@redhat.com>

On 01/15/2012 08:36 AM, Avi Kivity wrote:
> kvm dirty logging is broken in the presence of memory slots being
> removed; this breaks opensuse's boot screen.  Following patch fixes:
>
>    git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git memory/urgent

Pulled.  Thanks.

Regards,

Anthony Liguori

>
> Avi Kivity (1):
>        kvm: flush the dirty log when unregistering a slot
>
>   kvm-all.c |    4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/kvm-all.c b/kvm-all.c
> index 3174f42..2cc4562 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -566,6 +566,10 @@ static void kvm_set_phys_mem(MemoryRegionSection
> *section, bool add)
>
>           old = *mem;
>
> +        if (mem->flags&  KVM_MEM_LOG_DIRTY_PAGES) {
> +            kvm_physical_sync_dirty_bitmap(section);
> +        }
> +
>           /* unregister the overlapping slot */
>           mem->memory_size = 0;
>           err = kvm_set_user_memory_region(s, mem);
>

      reply	other threads:[~2012-01-15 16:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-15 14:36 [Qemu-devel] [PULL] Fix for kvm dirty logging Avi Kivity
2012-01-15 16:23 ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F12FD7A.1010301@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.