All of lore.kernel.org
 help / color / mirror / Atom feed
From: walt <w41ter@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Eric Paris <eparis@redhat.com>
Subject: [BISECTED] commit d2a7009f breaks xkbconf
Date: Sun, 15 Jan 2012 11:04:24 -0800	[thread overview]
Message-ID: <4F132338.5000104@gmail.com> (raw)

Hi Eric.  The commit below causes a very strange error while running startx.

While X is starting up it runs xkbcomp, which then prints "ERROR: Cannot
open /usr/share/X11/xkb/compiled/server-0.xkm to write keyboard description"
and then X shuts down.  Reverting the commit below fixes the error:

commit d2a7009f0bb03fa22ad08dd25472efa0568126b9
Author: Eric Paris
Date:   Tue Jan 3 12:25:15 2012 -0500

    capabitlies: ns_capable can use the cap helpers rather than lsm call
    
    Just to reduce the number of places to change if we every change the LSM
    hook, use the capability helpers internally when possible.

diff --git a/kernel/capability.c b/kernel/capability.c
index 5f99e5d..4762644 100644
--- a/kernel/capability.c
+++ b/kernel/capability.c
@@ -384,7 +384,7 @@ bool ns_capable(struct user_namespace *ns, int cap)
                BUG();
        }
 
-       if (security_capable(current_cred(), ns, cap) == 0) {
+       if (has_ns_capability(current, ns, cap)) {
                current->flags |= PF_SUPERPRIV;
                return true;
        }


                 reply	other threads:[~2012-01-15 19:04 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F132338.5000104@gmail.com \
    --to=w41ter@gmail.com \
    --cc=eparis@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.